Files
nur-falah-prevention/e2e-fastpath.cjs
wmj b9a98bd97a Restore all 8 pre-auth E2E suites with a sign-in prelude; fix bugs they found
New e2e-auth-helper.cjs: shared signInFreshFamily() prelude — signs in as
the confirmed test owner account and creates a uniquely-named family per
run, so accumulated data from a previous run's assets/hibah/etc. (now
persisted in Supabase, not wiped with the browser context like localStorage
was) can never bleed into another run's percentage/coverage assertions.
All 8 suites (e2e-uat, e2e-fastpath, e2e-trust, e2e-business,
e2e-digital-vehicle, e2e-property, e2e-other, e2e-info) now call it in
place of the old anonymous page.goto(BASE).

Restoring them surfaced two real product bugs, not just test staleness:

1. WassiyahGenerator.svelte was never migrated to Supabase in the earlier
   backend work — it still called the old local storage.js load()/save()
   for assets, bequests, and witnesses, so the one-third meter silently
   read an empty local cache and always showed 0. Migrated to family-scoped
   Supabase tables (new nf_wassiyah_bequests, nf_wassiyah_settings, with
   member-scoped RLS) matching the pattern used for Hibah/Nominations/etc.

2. storage.js's exportAll() did an unguarded JSON.parse on every
   "nf."-prefixed localStorage key, but family.js stores activeFamilyId as
   a raw string (not JSON-encoded) — one malformed parse threw and silently
   aborted the whole export before the file download fired. Made exportAll
   defensive: falls back to the raw string on a parse failure instead of
   throwing.

The remaining test failures were async-timing gaps inherent to the move
from synchronous localStorage reads to async Supabase fetches: several
assertions checked <select> option counts or newly-created rows immediately
after a fixed short wait, before the async load/refresh had actually
landed. Fixed by replacing blind isVisible()/fixed-timeout checks with
proper waitFor()/polling in the test helpers (selectByText, corpus-select
population, row-creation checks) — not a product bug, but worth fixing
since the old timing assumptions no longer hold now that data is live and
shared instead of instant and local.

Results: e2e-uat 32/32, e2e-fastpath 16/16, e2e-trust 12/12,
e2e-business 10/10, e2e-digital-vehicle 10/10, e2e-property 9/9,
e2e-other 4/4, e2e-info 31/31 — 124/124. Re-verified e2e-family-agent
(12/12) and e2e-smoke-authed (24/24) still pass after the
WassiyahGenerator migration. 160/160 total across all ten suites.
2026-08-13 21:30:46 +08:00

128 lines
7.2 KiB
JavaScript

// Targeted E2E for the new fast-path mechanism: Coverage, Hibah asset-link,
// Waqf corpus-link, Nomination, Death Trigger. Run after the general e2e-uat.cjs.
const { chromium } = require('playwright');
const { signInFreshFamily } = require('./e2e-auth-helper.cjs');
const BASE = 'https://moslem04.falahos.my/';
const results = [];
const consoleErrors = [];
function record(name, pass, detail = '') { results.push({ name, pass, detail }); console.log(`${pass ? 'PASS' : 'FAIL'} ${name}${detail ? ' — ' + detail : ''}`); }
async function main() {
const browser = await chromium.launch();
const page = await browser.newPage({ viewport: { width: 390, height: 844 } });
page.on('console', m => { if (m.type() === 'error') consoleErrors.push(m.text()); });
page.on('pageerror', e => consoleErrors.push(e.message));
await signInFreshFamily(page, BASE, 'e2e-fastpath');
const clickTab = async label => { await page.locator('nav button.tab', { hasText: label }).click(); await page.waitForTimeout(500); };
// New tabs exist
for (const label of ['Coverage', 'Nominate', 'Trigger']) {
const visible = await page.locator('nav button.tab', { hasText: label }).isVisible();
record(`Nav: "${label}" tab exists`, visible);
}
// Add an asset
await clickTab('Assets');
await page.locator('.field:has-text("Description") input').fill('Land parcel, Perak');
await page.locator('.field:has-text("Estimated value") input').fill('400000');
await page.locator('button.btn-primary', { hasText: 'Add asset' }).click();
await page.waitForTimeout(500);
// Coverage should show 0% before any fast-path instrument
await clickTab('Coverage');
const pctBefore = await page.locator('.big-percent').textContent();
record('Coverage: shows 0% before any fast-path instrument attached', pctBefore.trim() === '0%', pctBefore);
const warningVisible = await page.locator('.warning-box').isVisible();
record('Coverage: warning box shown when exposure > 0', warningVisible);
// Link the asset via Hibah
await clickTab('Hibah');
await page.locator('.field:has-text("Recipient") input').fill('My Nephew');
await page.locator('.field:has-text("Relation to you") input').fill('nephew');
await page.locator('.field:has-text("Asset / gift description") input').fill('Land parcel gift');
const linkSelect = page.locator('select').first();
await linkSelect.locator('option').nth(1).waitFor({ state: 'attached', timeout: 10000 }).catch(() => {});
await linkSelect.selectOption({ index: 1 });
await page.locator('button.btn-primary', { hasText: 'Log this hibah' }).click();
await page.waitForTimeout(500);
await page.locator('.guard-buttons button.btn-secondary', { hasText: 'No' }).click();
await page.waitForTimeout(500);
await page.locator('button.btn-primary', { hasText: 'Confirm and save' }).click();
const fastBadgeVisible = await page.locator('.fast-badge').waitFor({ state: 'visible', timeout: 10000 }).then(() => true).catch(() => false);
record('Hibah: linked gift shows fast-path badge', fastBadgeVisible);
// Coverage should now show 100%
await clickTab('Coverage');
const pctAfter = await page.locator('.big-percent').textContent();
record('Coverage: reflects 100% after asset linked to completed Hibah', pctAfter.trim() === '100%', pctAfter);
const successVisible = await page.locator('.success-box').isVisible();
record('Coverage: success box shown at full coverage', successVisible);
// Wassiyah slow-path warning
await clickTab('Wassiyah');
const slowWarningVisible = await page.locator('.slow-path-warning').isVisible();
const slowWarningText = await page.locator('.slow-path-warning').textContent();
record('Wassiyah: slow-path warning visible and explicit', slowWarningVisible && slowWarningText.includes('does not bypass'));
// Nomination Registry basic flow
await clickTab('Assets');
await page.locator('.field:has-text("Description") input').fill('EPF savings');
await page.locator('.field:has-text("Estimated value") input').fill('200000');
await page.locator('.form-card select').first().selectOption('Cash / Bank');
await page.locator('button.btn-primary', { hasText: 'Add asset' }).click();
await page.waitForTimeout(500);
await clickTab('Nominate');
const nomSelect = page.locator('select').first();
await nomSelect.locator('option').nth(1).waitFor({ state: 'attached', timeout: 10000 }).catch(() => {});
const epfVal = await nomSelect.evaluate(el => Array.from(el.options).find(o => o.textContent.includes('EPF savings'))?.value);
await nomSelect.selectOption(epfVal || { index: 1 });
await page.locator('.field:has-text("Nominee name") input').fill('My Wife');
await page.locator('.field:has-text("Institution") input').fill('KWSP');
await page.locator('button.btn-primary', { hasText: 'Add nomination' }).click();
const nominationRowVisible = await page.locator('.nomination-row', { hasText: 'My Wife' }).waitFor({ state: 'visible', timeout: 10000 }).then(() => true).catch(() => false);
record('Nomination: adding a nomination creates a row', nominationRowVisible);
// Death Trigger: cannot fire without threshold
await clickTab('Trigger');
const fireBtnDisabledInitially = await page.locator('button.btn-danger-solid').isDisabled();
record('Death Trigger: fire button disabled with no attestor confirmations', fireBtnDisabledInitially);
const attestorInputs = page.locator('.attestor-row input');
await attestorInputs.nth(0).fill('Executor Ahmad');
await page.locator('.attestor-row .confirm-btn').nth(0).click();
await attestorInputs.nth(1).fill('Witness Fatimah');
await page.locator('.attestor-row .confirm-btn').nth(1).click();
await page.locator('.field:has-text("Date of death") input').fill('2026-08-13');
await page.locator('.field:has-text("Death certificate reference") input').fill('DC-2026-00123');
await page.waitForTimeout(500);
const fireBtnEnabled = await page.locator('button.btn-danger-solid').isEnabled();
record('Death Trigger: fire button enables once 2 attestors confirm + cert ref present', fireBtnEnabled);
await page.locator('button.btn-danger-solid').click();
await page.waitForTimeout(600);
const triggeredBannerVisible = await page.locator('.triggered-banner').isVisible();
record('Death Trigger: fires and shows triggered banner', triggeredBannerVisible);
const packetRowVisible = await page.locator('.packet-row').first().isVisible();
record('Death Trigger: execution packet(s) generated for covered assets', packetRowVisible);
const [download] = await Promise.all([
page.waitForEvent('download'),
page.locator('.packet-row .btn-small').first().click()
]);
record('Death Trigger: packet download works', download.suggestedFilename().includes('execution-packet'), download.suggestedFilename());
record('No uncaught JS console errors during fast-path session', consoleErrors.length === 0, consoleErrors.join(' || '));
await browser.close();
const passCount = results.filter(r => r.pass).length;
const failCount = results.length - passCount;
console.log(`\n${passCount} passed, ${failCount} failed, ${results.length} total`);
if (failCount > 0) results.filter(r => !r.pass).forEach(r => console.log(` - ${r.name}: ${r.detail}`));
process.exit(failCount > 0 ? 1 : 0);
}
main().catch(e => { console.error('SCRIPT ERROR:', e); process.exit(2); });