Files
nur-falah-prevention/e2e-digital-vehicle.cjs
wmj 33a821e61d refactor: restructure navigation into 5 grouped hubs, off the 22-item flat strip
Implements the researched IA fix: mobile nav UX consensus caps primary
destinations at 4-5 (uxpin.com, fintech/banking 2026 UX research), and
this app had grown to 22 tabs in one horizontally-scrolling row —
exactly the anti-pattern that research flags for choice paralysis and
slower task completion.

New structure — 5 bottom-nav hubs, grouped by what the user is actually
trying to do, not build order:
- Home: Coverage (unchanged, still the landing screen)
- Estate: Assets, Faraid, Insurance, Wassiyah, Hibah, Family Waqf,
  Nominate, Claims (H2)
- Giving: Zakat, Sadaqah, Khairat
- Family: Tree, Trigger, Mutawalli, Manage (was 'Family', renamed to
  avoid colliding with the hub's own label), Neighbourhood
- Daily: Prayer Times, Qibla, Quran, Locate

Each hub reveals its own sub-nav one tap in, instead of every tab
competing for space in a single row. Settings moved out of the tab
strip entirely into a header gear icon, matching the banking-app pattern
of keeping settings out of primary thumb-reach real estate. The bottom
nav is now fixed (thumb-zone), sub-nav keeps the old sticky-top position.

Cross-component navigation (nav.js requestedTab, used by the Family
Tree's 'give sadaqah in memory' link) now resolves a tab label to its
owning (hub, sub-tab) pair instead of a flat index — verified live.

This touches every E2E suite: a single click on a tab's old selector no
longer reaches it (hub, then sub-tab). Added a shared gotoTab(page, label)
helper to e2e-auth-helper.cjs encapsulating the two-step navigation, and
migrated all ~22 affected test files off direct nav-button selectors —
mechanical substitution followed by manual fixes for local clickTab
wrappers, template-literal selectors, and active-state assertions that
needed to target the new .hub-tab/.subnav structure specifically.

Full regression after migration: every suite passes (one isolated
Family Tree flake confirmed clean on rerun, unrelated to navigation).
2026-08-14 14:55:09 +08:00

124 lines
6.8 KiB
JavaScript

// Verifies digital assets get covered via a proper digital-custody plan (not the
// mismatched bank-mandate fields), and vehicles get correctly suggested Hibah
// (not overkill trust structure) and can actually be covered that way.
const { chromium } = require('playwright');
const { signInFreshFamily, gotoTab } = require('./e2e-auth-helper.cjs');
const BASE = 'https://moslem04.falahos.my/';
const results = [];
const consoleErrors = [];
function record(name, pass, detail = '') { results.push({ name, pass, detail }); console.log(`${pass ? 'PASS' : 'FAIL'} ${name}${detail ? ' — ' + detail : ''}`); }
async function main() {
const browser = await chromium.launch();
const page = await browser.newPage({ viewport: { width: 390, height: 844 } });
page.on('console', m => { if (m.type() === 'error') consoleErrors.push(m.text()); });
page.on('pageerror', e => consoleErrors.push(e.message));
await signInFreshFamily(page, BASE, 'e2e-digital-vehicle');
const clickTab = async label => { await gotoTab(page, label); await page.waitForTimeout(500); };
const selectByText = async (locator, text) => {
// Options load async from Supabase now — poll until the matching one shows up.
let val;
for (let i = 0; i < 20; i++) {
val = await locator.evaluate((el, t) => Array.from(el.options).find(o => o.textContent.includes(t))?.value, text);
if (val) break;
await new Promise(r => setTimeout(r, 300));
}
await locator.selectOption(val);
};
// ── Digital asset ──
await clickTab('Assets');
await page.locator('.field:has-text("Description") input').fill('Bitcoin cold wallet');
await page.locator('.field:has-text("Estimated value") input').fill('150000');
await page.locator('.form-card select').first().selectOption('Digital assets');
await page.locator('button.btn-primary', { hasText: 'Add asset' }).click();
await page.waitForTimeout(500);
await clickTab('Coverage');
const digitalRowBefore = await page.locator('.asset-row', { hasText: 'Bitcoin' }).textContent();
record('Coverage: digital asset suggests Digital custody plan (not mismatched Multi-sig/bank-mandate label)', digitalRowBefore.includes('Digital custody plan'), digitalRowBefore.trim().slice(0, 200));
await clickTab('Nominate');
await selectByText(page.locator('select').first(), 'Bitcoin');
await page.waitForTimeout(500);
await page.locator('.form-card select').nth(1).selectOption('digital-custody');
await page.waitForTimeout(500);
const digitalFieldsVisible = await page.locator('.trust-fields').isVisible();
record('Nomination: digital-custody-specific fields appear', digitalFieldsVisible);
// Switch to multisig -> warning appears (only one select in the digital-custody fields: Custody type)
const custodySelect = page.locator('.trust-fields select').nth(0);
await custodySelect.selectOption('multisig');
await page.waitForTimeout(500);
const multisigWarningVisible = await page.locator('.business-warning').isVisible();
record('Nomination: multi-sig custody shows the co-signer-setup warning', multisigWarningVisible);
await custodySelect.selectOption('key-escrow');
await page.waitForTimeout(500);
const escrowWarningVisible = await page.locator('.business-warning').isVisible();
const escrowWarningText = await page.locator('.business-warning').textContent();
record('Nomination: key-escrow shows "never store the actual key" warning', escrowWarningVisible && escrowWarningText.includes('Never store'), escrowWarningText.trim().slice(0, 150));
const digitalInputs = page.locator('.trust-fields input');
await digitalInputs.nth(0).fill('Ledger self-custody');
await digitalInputs.nth(1).fill('Executor Ahmad');
await digitalInputs.nth(2).fill('Sealed instructions with lawyer, ref #45');
await page.locator('button.btn-primary', { hasText: 'digital custody plan' }).click();
await page.waitForTimeout(600);
const digitalRowCreated = await page.locator('.nomination-row', { hasText: 'Bitcoin' }).isVisible();
record('Nomination: digital custody row created', digitalRowCreated);
const [dlDigital] = await Promise.all([
page.waitForEvent('download'),
page.locator('.nomination-row', { hasText: 'Bitcoin' }).locator('.export-btn').click()
]);
record('Nomination: digital custody plan export downloads, no seed phrase in filename/content risk', dlDigital.suggestedFilename() === 'digital-custody-plan-draft.txt', dlDigital.suggestedFilename());
await clickTab('Coverage');
const digitalPct = await page.locator('.big-percent').textContent();
record('Coverage: digital asset now covered', digitalPct.trim() === '100%', digitalPct);
// ── Vehicle ──
await clickTab('Assets');
await page.locator('.field:has-text("Description") input').fill('Toyota Vios');
await page.locator('.field:has-text("Estimated value") input').fill('45000');
await page.locator('.form-card select').first().selectOption('Vehicle');
await page.locator('button.btn-primary', { hasText: 'Add asset' }).click();
await page.waitForTimeout(500);
await clickTab('Coverage');
const vehicleRowBefore = await page.locator('.asset-row', { hasText: 'Toyota' }).textContent();
record('Coverage: vehicle suggests Hibah directly (not overkill trust structure)', vehicleRowBefore.includes('Hibah') && !vehicleRowBefore.includes('trust setup'), vehicleRowBefore.trim().slice(0, 200));
// Cover the vehicle via Hibah
await clickTab('Hibah');
await page.locator('.field:has-text("Recipient") input').fill('My Son');
await page.locator('.field:has-text("Relation to you") input').fill('nephew');
await page.locator('.field:has-text("Asset / gift description") input').fill('Car gift');
const linkSelect = page.locator('select').first();
await selectByText(linkSelect, 'Toyota');
await page.locator('button.btn-primary', { hasText: 'Log this hibah' }).click();
await page.waitForTimeout(500);
await page.locator('.guard-buttons button.btn-secondary', { hasText: 'No' }).click();
await page.waitForTimeout(500);
await page.locator('button.btn-primary', { hasText: 'Confirm and save' }).click();
await page.waitForTimeout(500);
await clickTab('Coverage');
const overallPct = await page.locator('.big-percent').textContent();
record('Coverage: 100% after digital asset (custody) + vehicle (hibah) both covered', overallPct.trim() === '100%', overallPct);
record('No uncaught JS console errors', consoleErrors.length === 0, consoleErrors.join(' || '));
await browser.close();
const passCount = results.filter(r => r.pass).length;
const failCount = results.length - passCount;
console.log(`\n${passCount} passed, ${failCount} failed, ${results.length} total`);
if (failCount > 0) results.filter(r => !r.pass).forEach(r => console.log(` - ${r.name}: ${r.detail}`));
process.exit(failCount > 0 ? 1 : 0);
}
main().catch(e => { console.error('SCRIPT ERROR:', e); process.exit(2); });