Files
wmj 33a821e61d refactor: restructure navigation into 5 grouped hubs, off the 22-item flat strip
Implements the researched IA fix: mobile nav UX consensus caps primary
destinations at 4-5 (uxpin.com, fintech/banking 2026 UX research), and
this app had grown to 22 tabs in one horizontally-scrolling row —
exactly the anti-pattern that research flags for choice paralysis and
slower task completion.

New structure — 5 bottom-nav hubs, grouped by what the user is actually
trying to do, not build order:
- Home: Coverage (unchanged, still the landing screen)
- Estate: Assets, Faraid, Insurance, Wassiyah, Hibah, Family Waqf,
  Nominate, Claims (H2)
- Giving: Zakat, Sadaqah, Khairat
- Family: Tree, Trigger, Mutawalli, Manage (was 'Family', renamed to
  avoid colliding with the hub's own label), Neighbourhood
- Daily: Prayer Times, Qibla, Quran, Locate

Each hub reveals its own sub-nav one tap in, instead of every tab
competing for space in a single row. Settings moved out of the tab
strip entirely into a header gear icon, matching the banking-app pattern
of keeping settings out of primary thumb-reach real estate. The bottom
nav is now fixed (thumb-zone), sub-nav keeps the old sticky-top position.

Cross-component navigation (nav.js requestedTab, used by the Family
Tree's 'give sadaqah in memory' link) now resolves a tab label to its
owning (hub, sub-tab) pair instead of a flat index — verified live.

This touches every E2E suite: a single click on a tab's old selector no
longer reaches it (hub, then sub-tab). Added a shared gotoTab(page, label)
helper to e2e-auth-helper.cjs encapsulating the two-step navigation, and
migrated all ~22 affected test files off direct nav-button selectors —
mechanical substitution followed by manual fixes for local clickTab
wrappers, template-literal selectors, and active-state assertions that
needed to target the new .hub-tab/.subnav structure specifically.

Full regression after migration: every suite passes (one isolated
Family Tree flake confirmed clean on rerun, unrelated to navigation).
2026-08-14 14:55:09 +08:00

125 lines
6.9 KiB
JavaScript

// Verifies business interests get covered via a proper continuity instrument,
// including the sole-proprietorship warning and the waqf-enterprise redirect.
const { chromium } = require('playwright');
const { signInFreshFamily, gotoTab } = require('./e2e-auth-helper.cjs');
const BASE = 'https://moslem04.falahos.my/';
const results = [];
const consoleErrors = [];
function record(name, pass, detail = '') { results.push({ name, pass, detail }); console.log(`${pass ? 'PASS' : 'FAIL'} ${name}${detail ? ' — ' + detail : ''}`); }
async function main() {
const browser = await chromium.launch();
const page = await browser.newPage({ viewport: { width: 390, height: 844 } });
page.on('console', m => { if (m.type() === 'error') consoleErrors.push(m.text()); });
page.on('pageerror', e => consoleErrors.push(e.message));
await signInFreshFamily(page, BASE, 'e2e-business');
const clickTab = async label => { await gotoTab(page, label); await page.waitForTimeout(500); };
const selectByText = async (locator, text) => {
// Options load async from Supabase now — poll until the matching one shows up.
let val;
for (let i = 0; i < 20; i++) {
val = await locator.evaluate((el, t) => Array.from(el.options).find(o => o.textContent.includes(t))?.value, text);
if (val) break;
await new Promise(r => setTimeout(r, 300));
}
await locator.selectOption(val);
};
// Add a company-shares business asset
await clickTab('Assets');
await page.locator('.field:has-text("Description") input').fill('Bakery Sdn Bhd shares');
await page.locator('.field:has-text("Estimated value") input').fill('300000');
await page.locator('.form-card select').first().selectOption('Business interest');
await page.locator('button.btn-primary', { hasText: 'Add asset' }).click();
await page.waitForTimeout(500);
await clickTab('Coverage');
const rowBefore = await page.locator('.asset-row', { hasText: 'Bakery' }).textContent();
record('Coverage: business interest initially exposed with continuity suggestion', rowBefore.includes('Not covered') && /business continuity/i.test(rowBefore), rowBefore.trim().slice(0, 200));
// Go to Nominate, select business-continuity channel
await clickTab('Nominate');
await selectByText(page.locator('select').first(), 'Bakery');
await page.waitForTimeout(500);
await page.locator('.form-card select').nth(1).selectOption('business-continuity');
await page.waitForTimeout(500);
const businessFieldsVisible = await page.locator('.trust-fields').isVisible();
record('Nomination: business continuity fields appear', businessFieldsVisible);
// Default structure = company, default instrument = shareholder-buy-sell — no warning expected
const warningVisibleForCompany = await page.locator('.business-warning').isVisible().catch(() => false);
record('Nomination: no sole-prop warning shown for company structure', !warningVisibleForCompany);
// Switch to sole proprietorship -> warning should appear
await page.locator('.trust-fields select').first().selectOption('sole-prop');
await page.waitForTimeout(500);
const soleWarningVisible = await page.locator('.business-warning').first().isVisible();
const soleWarningText = await page.locator('.business-warning').first().textContent();
record('Nomination: sole-proprietorship shows "dies with you" warning', soleWarningVisible && soleWarningText.includes('dies with you'), soleWarningText.trim().slice(0, 150));
// Switch back to company, pick shareholder buy-sell, fill and save
await page.locator('.trust-fields select').first().selectOption('company');
await page.waitForTimeout(500);
const instrumentSelect = page.locator('.trust-fields select').nth(1);
await instrumentSelect.selectOption('shareholder-buy-sell');
await page.waitForTimeout(500);
const inputs = page.locator('.trust-fields .field input');
await inputs.nth(0).fill('Co-founder Rahman');
await inputs.nth(1).fill('Fair market valuation, Takaful-funded');
await page.locator('button.btn-primary', { hasText: 'Add business continuity instrument' }).click();
await page.waitForTimeout(600);
const rowCreated = await page.locator('.nomination-row', { hasText: 'Bakery' }).waitFor({ state: 'visible', timeout: 10000 }).then(() => true).catch(() => false);
record('Nomination: business continuity row created', rowCreated);
const [download] = await Promise.all([
page.waitForEvent('download'),
page.locator('.nomination-row', { hasText: 'Bakery' }).locator('.export-btn').click()
]);
record('Nomination: business continuity export downloads', download.suggestedFilename() === 'business-continuity-draft.txt', download.suggestedFilename());
// Coverage should now show 100%
await clickTab('Coverage');
const pct = await page.locator('.big-percent').textContent();
record('Coverage: business interest now covered (100%)', pct.trim() === '100%', pct);
// Waqf-enterprise redirect path: try selecting it and confirm Add button disables
await clickTab('Nominate');
await page.locator('.form-card select').nth(1).selectOption('business-continuity');
await page.waitForTimeout(500);
await page.locator('.trust-fields select').nth(1).selectOption('waqf-enterprise');
await page.waitForTimeout(500);
const redirectNoteVisible = await page.locator('.business-warning', { hasText: 'Family Waqf Designator' }).isVisible();
const addDisabled = await page.locator('button.btn-primary', { hasText: 'business continuity' }).isDisabled();
record('Nomination: waqf-enterprise option redirects to Family Waqf, disables Add', redirectNoteVisible && addDisabled);
// Death Trigger packet for business asset
await clickTab('Trigger');
const attestorInputs = page.locator('.attestor-row input');
await attestorInputs.nth(0).fill('Executor A');
await page.locator('.attestor-row .confirm-btn').nth(0).click();
await attestorInputs.nth(1).fill('Witness B');
await page.locator('.attestor-row .confirm-btn').nth(1).click();
await page.locator('.field:has-text("Date of death") input').fill('2026-08-13');
await page.locator('.field:has-text("Death certificate reference") input').fill('DC-BIZ-001');
await page.waitForTimeout(500);
await page.locator('button.btn-danger-solid').click();
await page.waitForTimeout(600);
const packetForBiz = await page.locator('.packet-row', { hasText: 'Bakery' }).isVisible();
record('Death Trigger: execution packet generated for business via continuity instrument', packetForBiz);
record('No uncaught JS console errors', consoleErrors.length === 0, consoleErrors.join(' || '));
await browser.close();
const passCount = results.filter(r => r.pass).length;
const failCount = results.length - passCount;
console.log(`\n${passCount} passed, ${failCount} failed, ${results.length} total`);
if (failCount > 0) results.filter(r => !r.pass).forEach(r => console.log(` - ${r.name}: ${r.detail}`));
process.exit(failCount > 0 ? 1 : 0);
}
main().catch(e => { console.error('SCRIPT ERROR:', e); process.exit(2); });