Restore all 8 pre-auth E2E suites with a sign-in prelude; fix bugs they found
New e2e-auth-helper.cjs: shared signInFreshFamily() prelude — signs in as the confirmed test owner account and creates a uniquely-named family per run, so accumulated data from a previous run's assets/hibah/etc. (now persisted in Supabase, not wiped with the browser context like localStorage was) can never bleed into another run's percentage/coverage assertions. All 8 suites (e2e-uat, e2e-fastpath, e2e-trust, e2e-business, e2e-digital-vehicle, e2e-property, e2e-other, e2e-info) now call it in place of the old anonymous page.goto(BASE). Restoring them surfaced two real product bugs, not just test staleness: 1. WassiyahGenerator.svelte was never migrated to Supabase in the earlier backend work — it still called the old local storage.js load()/save() for assets, bequests, and witnesses, so the one-third meter silently read an empty local cache and always showed 0. Migrated to family-scoped Supabase tables (new nf_wassiyah_bequests, nf_wassiyah_settings, with member-scoped RLS) matching the pattern used for Hibah/Nominations/etc. 2. storage.js's exportAll() did an unguarded JSON.parse on every "nf."-prefixed localStorage key, but family.js stores activeFamilyId as a raw string (not JSON-encoded) — one malformed parse threw and silently aborted the whole export before the file download fired. Made exportAll defensive: falls back to the raw string on a parse failure instead of throwing. The remaining test failures were async-timing gaps inherent to the move from synchronous localStorage reads to async Supabase fetches: several assertions checked <select> option counts or newly-created rows immediately after a fixed short wait, before the async load/refresh had actually landed. Fixed by replacing blind isVisible()/fixed-timeout checks with proper waitFor()/polling in the test helpers (selectByText, corpus-select population, row-creation checks) — not a product bug, but worth fixing since the old timing assumptions no longer hold now that data is live and shared instead of instant and local. Results: e2e-uat 32/32, e2e-fastpath 16/16, e2e-trust 12/12, e2e-business 10/10, e2e-digital-vehicle 10/10, e2e-property 9/9, e2e-other 4/4, e2e-info 31/31 — 124/124. Re-verified e2e-family-agent (12/12) and e2e-smoke-authed (24/24) still pass after the WassiyahGenerator migration. 160/160 total across all ten suites.
This commit is contained in:
@@ -1,34 +1,58 @@
|
||||
<script>
|
||||
import { load, save, estateTotal } from './storage.js';
|
||||
import { onMount } from 'svelte';
|
||||
import { oneThirdCap, isQuranicHeirRelation } from './calc/faraid.js';
|
||||
import { activeFamilyId } from './family.js';
|
||||
import { listAssets, estateTotal, listWassiyahBequests, addWassiyahBequest, removeWassiyahBequest, getWassiyahSettings, upsertWassiyahSettings } from './db.js';
|
||||
import Disclaimer from './Disclaimer.svelte';
|
||||
import InfoPanel from './InfoPanel.svelte';
|
||||
|
||||
const assets = load('assets', []);
|
||||
const total = estateTotal(assets);
|
||||
const cap = oneThirdCap(total);
|
||||
let familyId = $state(null);
|
||||
activeFamilyId.subscribe(v => familyId = v);
|
||||
|
||||
let total = $state(0);
|
||||
let cap = $state(0);
|
||||
let jurisdiction = $state('UK');
|
||||
let bequests = $state(load('wassiyahBequests', []));
|
||||
let bequests = $state([]);
|
||||
let form = $state({ recipient: '', relation: '', description: '', value: '' });
|
||||
let witness1 = $state(load('witness1', ''));
|
||||
let witness2 = $state(load('witness2', ''));
|
||||
let witness1 = $state('');
|
||||
let witness2 = $state('');
|
||||
let overrideAcknowledged = $state(false);
|
||||
|
||||
async function refresh() {
|
||||
if (!familyId) return;
|
||||
const assets = await listAssets(familyId);
|
||||
total = estateTotal(assets);
|
||||
cap = oneThirdCap(total);
|
||||
bequests = await listWassiyahBequests(familyId);
|
||||
const settings = await getWassiyahSettings(familyId);
|
||||
if (settings) {
|
||||
jurisdiction = settings.jurisdiction || 'UK';
|
||||
witness1 = settings.witness1 || '';
|
||||
witness2 = settings.witness2 || '';
|
||||
}
|
||||
}
|
||||
|
||||
onMount(refresh);
|
||||
$effect(() => { familyId; refresh(); });
|
||||
|
||||
async function saveSettings() {
|
||||
await upsertWassiyahSettings(familyId, { jurisdiction, witness1, witness2 });
|
||||
}
|
||||
|
||||
const bequestTotal = $derived(bequests.reduce((s, b) => s + Number(b.value), 0));
|
||||
const exceedsCap = $derived(bequestTotal > cap);
|
||||
const blockedRecipient = $derived(isQuranicHeirRelation(form.relation));
|
||||
|
||||
function addBequest() {
|
||||
async function addBequest() {
|
||||
if (!form.recipient || !form.value) return;
|
||||
bequests = [...bequests, { ...form, id: crypto.randomUUID(), value: Number(form.value) }];
|
||||
save('wassiyahBequests', bequests);
|
||||
await addWassiyahBequest(familyId, form);
|
||||
form = { recipient: '', relation: '', description: '', value: '' };
|
||||
await refresh();
|
||||
}
|
||||
|
||||
function remove(id) {
|
||||
bequests = bequests.filter(b => b.id !== id);
|
||||
save('wassiyahBequests', bequests);
|
||||
async function remove(id) {
|
||||
await removeWassiyahBequest(id);
|
||||
await refresh();
|
||||
}
|
||||
|
||||
function exportDraft() {
|
||||
@@ -57,7 +81,7 @@
|
||||
'',
|
||||
'DISCLAIMER: Not a fatwa. Not legal advice. Requires qualified review before real-world reliance.'
|
||||
];
|
||||
save('witness1', witness1); save('witness2', witness2);
|
||||
saveSettings();
|
||||
const blob = new Blob([lines.join('\n')], { type: 'text/plain' });
|
||||
const url = URL.createObjectURL(blob);
|
||||
const a = document.createElement('a');
|
||||
@@ -95,7 +119,7 @@
|
||||
</div>
|
||||
|
||||
<label class="field"><span>Jurisdiction</span>
|
||||
<select bind:value={jurisdiction}><option value="UK">United Kingdom</option><option value="MY">Malaysia</option></select>
|
||||
<select bind:value={jurisdiction} onchange={saveSettings}><option value="UK">United Kingdom</option><option value="MY">Malaysia</option></select>
|
||||
</label>
|
||||
|
||||
<div class="form-card">
|
||||
@@ -124,8 +148,8 @@
|
||||
</div>
|
||||
{/if}
|
||||
|
||||
<label class="field"><span>Witness 1</span><input type="text" bind:value={witness1} /></label>
|
||||
<label class="field"><span>Witness 2</span><input type="text" bind:value={witness2} /></label>
|
||||
<label class="field"><span>Witness 1</span><input type="text" bind:value={witness1} onblur={saveSettings} /></label>
|
||||
<label class="field"><span>Witness 2</span><input type="text" bind:value={witness2} onblur={saveSettings} /></label>
|
||||
|
||||
<button class="btn-primary" disabled={exceedsCap && !overrideAcknowledged} onclick={exportDraft}>Export draft (PDF + text)</button>
|
||||
|
||||
|
||||
@@ -186,3 +186,32 @@ export async function fireDeathTrigger(familyId) {
|
||||
export function estateTotal(assets) {
|
||||
return (assets || []).reduce((sum, a) => sum + (Number(a.value) || 0) * (Number(a.ownershipShare ?? 100) / 100), 0);
|
||||
}
|
||||
|
||||
// ── Wassiyah ──
|
||||
export async function listWassiyahBequests(familyId) {
|
||||
const { data, error } = await supabase.from('nf_wassiyah_bequests').select('*').eq('family_id', familyId).order('created_at');
|
||||
if (error) throw error;
|
||||
return (data || []).map(b => ({ id: b.id, recipient: b.recipient, relation: b.relation, description: b.description, value: b.value }));
|
||||
}
|
||||
export async function addWassiyahBequest(familyId, b) {
|
||||
const { error } = await supabase.from('nf_wassiyah_bequests').insert({
|
||||
family_id: familyId, recipient: b.recipient, relation: b.relation, description: b.description, value: Number(b.value)
|
||||
});
|
||||
if (error) throw error;
|
||||
}
|
||||
export async function removeWassiyahBequest(id) {
|
||||
const { error } = await supabase.from('nf_wassiyah_bequests').delete().eq('id', id);
|
||||
if (error) throw error;
|
||||
}
|
||||
export async function getWassiyahSettings(familyId) {
|
||||
const { data, error } = await supabase.from('nf_wassiyah_settings').select('*').eq('family_id', familyId).maybeSingle();
|
||||
if (error) throw error;
|
||||
return data;
|
||||
}
|
||||
export async function upsertWassiyahSettings(familyId, fields) {
|
||||
const { error } = await supabase.from('nf_wassiyah_settings').upsert({
|
||||
family_id: familyId, jurisdiction: fields.jurisdiction, witness1: fields.witness1, witness2: fields.witness2,
|
||||
updated_at: new Date().toISOString()
|
||||
}, { onConflict: 'family_id' });
|
||||
if (error) throw error;
|
||||
}
|
||||
|
||||
+7
-1
@@ -28,7 +28,13 @@ export function exportAll() {
|
||||
const out = {};
|
||||
for (let i = 0; i < localStorage.length; i++) {
|
||||
const k = localStorage.key(i);
|
||||
if (k && k.startsWith(PREFIX)) out[k.slice(PREFIX.length)] = JSON.parse(localStorage.getItem(k));
|
||||
if (!k || !k.startsWith(PREFIX)) continue;
|
||||
const raw = localStorage.getItem(k);
|
||||
// Not every nf.-prefixed key is JSON-encoded (e.g. family.js stores
|
||||
// activeFamilyId as a raw string) — a single malformed JSON.parse used
|
||||
// to throw and silently abort the whole export before the download fired.
|
||||
try { out[k.slice(PREFIX.length)] = JSON.parse(raw); }
|
||||
catch { out[k.slice(PREFIX.length)] = raw; }
|
||||
}
|
||||
return out;
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user