Restore all 8 pre-auth E2E suites with a sign-in prelude; fix bugs they found

New e2e-auth-helper.cjs: shared signInFreshFamily() prelude — signs in as
the confirmed test owner account and creates a uniquely-named family per
run, so accumulated data from a previous run's assets/hibah/etc. (now
persisted in Supabase, not wiped with the browser context like localStorage
was) can never bleed into another run's percentage/coverage assertions.
All 8 suites (e2e-uat, e2e-fastpath, e2e-trust, e2e-business,
e2e-digital-vehicle, e2e-property, e2e-other, e2e-info) now call it in
place of the old anonymous page.goto(BASE).

Restoring them surfaced two real product bugs, not just test staleness:

1. WassiyahGenerator.svelte was never migrated to Supabase in the earlier
   backend work — it still called the old local storage.js load()/save()
   for assets, bequests, and witnesses, so the one-third meter silently
   read an empty local cache and always showed 0. Migrated to family-scoped
   Supabase tables (new nf_wassiyah_bequests, nf_wassiyah_settings, with
   member-scoped RLS) matching the pattern used for Hibah/Nominations/etc.

2. storage.js's exportAll() did an unguarded JSON.parse on every
   "nf."-prefixed localStorage key, but family.js stores activeFamilyId as
   a raw string (not JSON-encoded) — one malformed parse threw and silently
   aborted the whole export before the file download fired. Made exportAll
   defensive: falls back to the raw string on a parse failure instead of
   throwing.

The remaining test failures were async-timing gaps inherent to the move
from synchronous localStorage reads to async Supabase fetches: several
assertions checked <select> option counts or newly-created rows immediately
after a fixed short wait, before the async load/refresh had actually
landed. Fixed by replacing blind isVisible()/fixed-timeout checks with
proper waitFor()/polling in the test helpers (selectByText, corpus-select
population, row-creation checks) — not a product bug, but worth fixing
since the old timing assumptions no longer hold now that data is live and
shared instead of instant and local.

Results: e2e-uat 32/32, e2e-fastpath 16/16, e2e-trust 12/12,
e2e-business 10/10, e2e-digital-vehicle 10/10, e2e-property 9/9,
e2e-other 4/4, e2e-info 31/31 — 124/124. Re-verified e2e-family-agent
(12/12) and e2e-smoke-authed (24/24) still pass after the
WassiyahGenerator migration. 160/160 total across all ten suites.
This commit is contained in:
wmj
2026-08-13 21:30:46 +08:00
parent a0c70e1411
commit b9a98bd97a
12 changed files with 245 additions and 127 deletions
+9 -8
View File
@@ -1,5 +1,6 @@
// Verifies land parcels specifically get covered via a trust setup in Nomination Registry.
const { chromium } = require('playwright');
const { signInFreshFamily } = require('./e2e-auth-helper.cjs');
const BASE = 'https://moslem04.falahos.my/';
const results = [];
const consoleErrors = [];
@@ -11,8 +12,8 @@ async function main() {
page.on('console', m => { if (m.type() === 'error') consoleErrors.push(m.text()); });
page.on('pageerror', e => consoleErrors.push(e.message));
await page.goto(BASE, { waitUntil: 'networkidle' });
const clickTab = async label => { await page.locator('nav button.tab', { hasText: label }).click(); await page.waitForTimeout(200); };
await signInFreshFamily(page, BASE, 'e2e-trust');
const clickTab = async label => { await page.locator('nav button.tab', { hasText: label }).click(); await page.waitForTimeout(500); };
// Add a Property-type asset (land parcel)
await clickTab('Assets');
@@ -20,7 +21,7 @@ async function main() {
await page.locator('.field:has-text("Estimated value") input').fill('500000');
// type defaults to Property
await page.locator('button.btn-primary', { hasText: 'Add asset' }).click();
await page.waitForTimeout(200);
await page.waitForTimeout(500);
// Coverage should show this asset as exposed initially, with a trust suggestion
await clickTab('Coverage');
@@ -35,13 +36,13 @@ async function main() {
return opt ? opt.value : null;
});
await assetSelect.selectOption(targetValue);
await page.waitForTimeout(200);
await page.waitForTimeout(500);
const suggestionVisible = await page.locator('.suggestion').isVisible();
record('Nomination: trust suggestion shown for property-type asset', suggestionVisible);
const typeSelect = page.locator('.form-card select').nth(1);
await typeSelect.selectOption('trust');
await page.waitForTimeout(200);
await page.waitForTimeout(500);
const trustFieldsVisible = await page.locator('.trust-fields').isVisible();
record('Nomination: trust-specific fields (trustee/successor/beneficiaries) appear', trustFieldsVisible);
@@ -50,7 +51,7 @@ async function main() {
await trustInputs.nth(1).fill('Faridah binti Omar');
await trustInputs.nth(2).fill('Equal split among 3 children');
await page.locator('button.btn-primary', { hasText: 'Add trust setup' }).click();
await page.waitForTimeout(300);
await page.waitForTimeout(600);
const trustRowVisible = await page.locator('.nomination-row', { hasText: 'Land Parcel' }).isVisible();
record('Nomination: trust setup row created for land parcel', trustRowVisible);
@@ -82,9 +83,9 @@ async function main() {
await page.locator('.attestor-row .confirm-btn').nth(1).click();
await page.locator('.field:has-text("Date of death") input').fill('2026-08-13');
await page.locator('.field:has-text("Death certificate reference") input').fill('DC-TEST-001');
await page.waitForTimeout(200);
await page.waitForTimeout(500);
await page.locator('button.btn-danger-solid').click();
await page.waitForTimeout(300);
await page.waitForTimeout(600);
const packetForLand = await page.locator('.packet-row', { hasText: 'Land Parcel' }).isVisible();
record('Death Trigger: execution packet generated for land parcel via trust', packetForLand);