wmj/nur-falah-prevention
1
0
Fork 0
Code Issues Pull Requests 1 Actions Packages Projects Releases Wiki Activity

Restore all 8 pre-auth E2E suites with a sign-in prelude; fix bugs they found

Browse Source 
New e2e-auth-helper.cjs: shared signInFreshFamily() prelude — signs in as
the confirmed test owner account and creates a uniquely-named family per
run, so accumulated data from a previous run's assets/hibah/etc. (now
persisted in Supabase, not wiped with the browser context like localStorage
was) can never bleed into another run's percentage/coverage assertions.
All 8 suites (e2e-uat, e2e-fastpath, e2e-trust, e2e-business,
e2e-digital-vehicle, e2e-property, e2e-other, e2e-info) now call it in
place of the old anonymous page.goto(BASE).

Restoring them surfaced two real product bugs, not just test staleness:

1. WassiyahGenerator.svelte was never migrated to Supabase in the earlier
   backend work — it still called the old local storage.js load()/save()
   for assets, bequests, and witnesses, so the one-third meter silently
   read an empty local cache and always showed 0. Migrated to family-scoped
   Supabase tables (new nf_wassiyah_bequests, nf_wassiyah_settings, with
   member-scoped RLS) matching the pattern used for Hibah/Nominations/etc.

2. storage.js's exportAll() did an unguarded JSON.parse on every
   "nf."-prefixed localStorage key, but family.js stores activeFamilyId as
   a raw string (not JSON-encoded) — one malformed parse threw and silently
   aborted the whole export before the file download fired. Made exportAll
   defensive: falls back to the raw string on a parse failure instead of
   throwing.

The remaining test failures were async-timing gaps inherent to the move
from synchronous localStorage reads to async Supabase fetches: several
assertions checked <select> option counts or newly-created rows immediately
after a fixed short wait, before the async load/refresh had actually
landed. Fixed by replacing blind isVisible()/fixed-timeout checks with
proper waitFor()/polling in the test helpers (selectByText, corpus-select
population, row-creation checks) — not a product bug, but worth fixing
since the old timing assumptions no longer hold now that data is live and
shared instead of instant and local.

Results: e2e-uat 32/32, e2e-fastpath 16/16, e2e-trust 12/12,
e2e-business 10/10, e2e-digital-vehicle 10/10, e2e-property 9/9,
e2e-other 4/4, e2e-info 31/31 — 124/124. Re-verified e2e-family-agent
(12/12) and e2e-smoke-authed (24/24) still pass after the
WassiyahGenerator migration. 160/160 total across all ten suites.
This commit is contained in:
wmj
2026-08-13 21:30:46 +08:00
parent a0c70e1411
commit b9a98bd97a
12 changed files with 245 additions and 127 deletions
Download Patch File Download Diff File Expand all files Collapse all files
e2e-property.cjs
+21 -14
View File
@@ -1,6 +1,7 @@
// Verifies property/land assets are covered through ALL THREE applicable fast-path
// channels: Hibah, Waqf (Family Waqf Designator), and Trust (Nomination Registry).
const { chromium } = require('playwright');
const { signInFreshFamily } = require('./e2e-auth-helper.cjs');
const BASE = 'https://moslem04.falahos.my/';
const results = [];
const consoleErrors = [];
@@ -12,10 +13,16 @@ async function main() {
page.on('console', m => { if (m.type() === 'error') consoleErrors.push(m.text()); });
page.on('pageerror', e => consoleErrors.push(e.message));
await page.goto(BASE, { waitUntil: 'networkidle' });
const clickTab = async label => { await page.locator('nav button.tab', { hasText: label }).click(); await page.waitForTimeout(200); };
await signInFreshFamily(page, BASE, 'e2e-property');
const clickTab = async label => { await page.locator('nav button.tab', { hasText: label }).click(); await page.waitForTimeout(500); };
const selectByText = async (locator, text) => {
const val = await locator.evaluate((el, t) => Array.from(el.options).find(o => o.textContent.includes(t))?.value, text);
// Options load async from Supabase now — poll until the matching one shows up.
let val;
for (let i = 0; i < 20; i++) {
val = await locator.evaluate((el, t) => Array.from(el.options).find(o => o.textContent.includes(t))?.value, text);
if (val) break;
await new Promise(r => setTimeout(r, 300));
}
await locator.selectOption(val);
};
@@ -26,7 +33,7 @@ async function main() {
await page.locator('.field:has-text("Estimated value") input').fill(val);
// Type defaults to Property — leave as-is
await page.locator('button.btn-primary', { hasText: 'Add asset' }).click();
await page.waitForTimeout(200);
await page.waitForTimeout(500);
}
await clickTab('Coverage');
@@ -42,11 +49,11 @@ async function main() {
await page.locator('.field:has-text("Asset / gift description") input').fill('House gift');
await selectByText(page.locator('select').first(), 'House A');
await page.locator('button.btn-primary', { hasText: 'Log this hibah' }).click();
await page.waitForTimeout(200);
await page.waitForTimeout(500);
await page.locator('.guard-buttons button.btn-secondary', { hasText: 'No' }).click();
await page.waitForTimeout(200);
await page.waitForTimeout(500);
await page.locator('button.btn-primary', { hasText: 'Confirm and save' }).click();
await page.waitForTimeout(300);
await page.waitForTimeout(600);
await clickTab('Coverage');
const houseARow = await page.locator('.asset-row', { hasText: 'House A' }).textContent();
@@ -55,11 +62,11 @@ async function main() {
// Channel 2: Waqf
await clickTab('Family Waqf');
await selectByText(page.locator('select').first(), 'House B');
await page.waitForTimeout(200);
await page.waitForTimeout(500);
const corpusVal = await page.locator('select').first().inputValue();
record('Family Waqf: House B selectable as corpus asset', corpusVal !== '');
await page.locator('.field:has-text("Mutawalli (trustee)") input').fill('Ahmad bin Ismail');
await page.waitForTimeout(300); // allow $effect to persist waqfCorpusAssetId
await page.waitForTimeout(600); // allow $effect to persist waqfCorpusAssetId
await clickTab('Coverage');
const houseBRow = await page.locator('.asset-row', { hasText: 'House B' }).textContent();
@@ -68,15 +75,15 @@ async function main() {
// Channel 3: Trust (Nomination Registry)
await clickTab('Nominate');
await selectByText(page.locator('select').first(), 'House C');
await page.waitForTimeout(200);
await page.waitForTimeout(500);
await page.locator('.form-card select').nth(1).selectOption('trust');
await page.waitForTimeout(200);
await page.waitForTimeout(500);
const trustInputs = page.locator('.trust-fields .field input');
await trustInputs.nth(0).fill('Trustee Co');
await trustInputs.nth(1).fill('Successor Trustee Co');
await trustInputs.nth(2).fill('Equal split among children');
await page.locator('button.btn-primary', { hasText: 'Add trust setup' }).click();
await page.waitForTimeout(300);
await page.waitForTimeout(600);
await clickTab('Coverage');
const houseCRow = await page.locator('.asset-row', { hasText: 'House C' }).textContent();
@@ -94,9 +101,9 @@ async function main() {
await page.locator('.attestor-row .confirm-btn').nth(1).click();
await page.locator('.field:has-text("Date of death") input').fill('2026-08-13');
await page.locator('.field:has-text("Death certificate reference") input').fill('DC-PROP-001');
await page.waitForTimeout(200);
await page.waitForTimeout(500);
await page.locator('button.btn-danger-solid').click();
await page.waitForTimeout(300);
await page.waitForTimeout(600);
const packetCount = await page.locator('.packet-row', { hasText: 'House' }).count();
record('Death Trigger: execution packets generated for all 3 property assets', packetCount === 3, `${packetCount} packets`);