Restore all 8 pre-auth E2E suites with a sign-in prelude; fix bugs they found
New e2e-auth-helper.cjs: shared signInFreshFamily() prelude — signs in as the confirmed test owner account and creates a uniquely-named family per run, so accumulated data from a previous run's assets/hibah/etc. (now persisted in Supabase, not wiped with the browser context like localStorage was) can never bleed into another run's percentage/coverage assertions. All 8 suites (e2e-uat, e2e-fastpath, e2e-trust, e2e-business, e2e-digital-vehicle, e2e-property, e2e-other, e2e-info) now call it in place of the old anonymous page.goto(BASE). Restoring them surfaced two real product bugs, not just test staleness: 1. WassiyahGenerator.svelte was never migrated to Supabase in the earlier backend work — it still called the old local storage.js load()/save() for assets, bequests, and witnesses, so the one-third meter silently read an empty local cache and always showed 0. Migrated to family-scoped Supabase tables (new nf_wassiyah_bequests, nf_wassiyah_settings, with member-scoped RLS) matching the pattern used for Hibah/Nominations/etc. 2. storage.js's exportAll() did an unguarded JSON.parse on every "nf."-prefixed localStorage key, but family.js stores activeFamilyId as a raw string (not JSON-encoded) — one malformed parse threw and silently aborted the whole export before the file download fired. Made exportAll defensive: falls back to the raw string on a parse failure instead of throwing. The remaining test failures were async-timing gaps inherent to the move from synchronous localStorage reads to async Supabase fetches: several assertions checked <select> option counts or newly-created rows immediately after a fixed short wait, before the async load/refresh had actually landed. Fixed by replacing blind isVisible()/fixed-timeout checks with proper waitFor()/polling in the test helpers (selectByText, corpus-select population, row-creation checks) — not a product bug, but worth fixing since the old timing assumptions no longer hold now that data is live and shared instead of instant and local. Results: e2e-uat 32/32, e2e-fastpath 16/16, e2e-trust 12/12, e2e-business 10/10, e2e-digital-vehicle 10/10, e2e-property 9/9, e2e-other 4/4, e2e-info 31/31 — 124/124. Re-verified e2e-family-agent (12/12) and e2e-smoke-authed (24/24) still pass after the WassiyahGenerator migration. 160/160 total across all ten suites.
This commit is contained in:
+15
-8
@@ -2,6 +2,7 @@
|
||||
// previous bug: a nonsensical "EPF / Takaful nomination" suggestion pointing at a
|
||||
// channel value ('nomination') that didn't even exist in the Nomination Registry.
|
||||
const { chromium } = require('playwright');
|
||||
const { signInFreshFamily } = require('./e2e-auth-helper.cjs');
|
||||
const BASE = 'https://moslem04.falahos.my/';
|
||||
const results = [];
|
||||
const consoleErrors = [];
|
||||
@@ -13,10 +14,16 @@ async function main() {
|
||||
page.on('console', m => { if (m.type() === 'error') consoleErrors.push(m.text()); });
|
||||
page.on('pageerror', e => consoleErrors.push(e.message));
|
||||
|
||||
await page.goto(BASE, { waitUntil: 'networkidle' });
|
||||
const clickTab = async label => { await page.locator('nav button.tab', { hasText: label }).click(); await page.waitForTimeout(200); };
|
||||
await signInFreshFamily(page, BASE, 'e2e-other');
|
||||
const clickTab = async label => { await page.locator('nav button.tab', { hasText: label }).click(); await page.waitForTimeout(500); };
|
||||
const selectByText = async (locator, text) => {
|
||||
const val = await locator.evaluate((el, t) => Array.from(el.options).find(o => o.textContent.includes(t))?.value, text);
|
||||
// Options load async from Supabase now — poll until the matching one shows up.
|
||||
let val;
|
||||
for (let i = 0; i < 20; i++) {
|
||||
val = await locator.evaluate((el, t) => Array.from(el.options).find(o => o.textContent.includes(t))?.value, text);
|
||||
if (val) break;
|
||||
await new Promise(r => setTimeout(r, 300));
|
||||
}
|
||||
await locator.selectOption(val);
|
||||
};
|
||||
|
||||
@@ -25,7 +32,7 @@ async function main() {
|
||||
await page.locator('.field:has-text("Estimated value") input').fill('20000');
|
||||
await page.locator('.form-card select').first().selectOption('Other');
|
||||
await page.locator('button.btn-primary', { hasText: 'Add asset' }).click();
|
||||
await page.waitForTimeout(200);
|
||||
await page.waitForTimeout(500);
|
||||
|
||||
await clickTab('Coverage');
|
||||
const rowBefore = await page.locator('.asset-row', { hasText: 'stamp collection' }).textContent();
|
||||
@@ -33,7 +40,7 @@ async function main() {
|
||||
|
||||
await clickTab('Nominate');
|
||||
await selectByText(page.locator('select').first(), 'stamp collection');
|
||||
await page.waitForTimeout(200);
|
||||
await page.waitForTimeout(500);
|
||||
const suggestionText = await page.locator('.suggestion').textContent();
|
||||
record('Nomination: suggestion for "Other" points to Hibah with sensible reasoning', suggestionText.includes('Hibah') && suggestionText.includes('safest general'), suggestionText.trim().slice(0, 200));
|
||||
|
||||
@@ -44,11 +51,11 @@ async function main() {
|
||||
await page.locator('.field:has-text("Asset / gift description") input').fill('Stamp collection gift');
|
||||
await selectByText(page.locator('select').first(), 'stamp collection');
|
||||
await page.locator('button.btn-primary', { hasText: 'Log this hibah' }).click();
|
||||
await page.waitForTimeout(200);
|
||||
await page.waitForTimeout(500);
|
||||
await page.locator('.guard-buttons button.btn-secondary', { hasText: 'No' }).click();
|
||||
await page.waitForTimeout(200);
|
||||
await page.waitForTimeout(500);
|
||||
await page.locator('button.btn-primary', { hasText: 'Confirm and save' }).click();
|
||||
await page.waitForTimeout(300);
|
||||
await page.waitForTimeout(600);
|
||||
|
||||
await clickTab('Coverage');
|
||||
const pct = await page.locator('.big-percent').textContent();
|
||||
|
||||
Reference in New Issue
Block a user