wmj/nur-falah-prevention
1
0
Fork 0
Code Issues Pull Requests 1 Actions Packages Projects Releases Wiki Activity

Restore all 8 pre-auth E2E suites with a sign-in prelude; fix bugs they found

Browse Source 
New e2e-auth-helper.cjs: shared signInFreshFamily() prelude — signs in as
the confirmed test owner account and creates a uniquely-named family per
run, so accumulated data from a previous run's assets/hibah/etc. (now
persisted in Supabase, not wiped with the browser context like localStorage
was) can never bleed into another run's percentage/coverage assertions.
All 8 suites (e2e-uat, e2e-fastpath, e2e-trust, e2e-business,
e2e-digital-vehicle, e2e-property, e2e-other, e2e-info) now call it in
place of the old anonymous page.goto(BASE).

Restoring them surfaced two real product bugs, not just test staleness:

1. WassiyahGenerator.svelte was never migrated to Supabase in the earlier
   backend work — it still called the old local storage.js load()/save()
   for assets, bequests, and witnesses, so the one-third meter silently
   read an empty local cache and always showed 0. Migrated to family-scoped
   Supabase tables (new nf_wassiyah_bequests, nf_wassiyah_settings, with
   member-scoped RLS) matching the pattern used for Hibah/Nominations/etc.

2. storage.js's exportAll() did an unguarded JSON.parse on every
   "nf."-prefixed localStorage key, but family.js stores activeFamilyId as
   a raw string (not JSON-encoded) — one malformed parse threw and silently
   aborted the whole export before the file download fired. Made exportAll
   defensive: falls back to the raw string on a parse failure instead of
   throwing.

The remaining test failures were async-timing gaps inherent to the move
from synchronous localStorage reads to async Supabase fetches: several
assertions checked <select> option counts or newly-created rows immediately
after a fixed short wait, before the async load/refresh had actually
landed. Fixed by replacing blind isVisible()/fixed-timeout checks with
proper waitFor()/polling in the test helpers (selectByText, corpus-select
population, row-creation checks) — not a product bug, but worth fixing
since the old timing assumptions no longer hold now that data is live and
shared instead of instant and local.

Results: e2e-uat 32/32, e2e-fastpath 16/16, e2e-trust 12/12,
e2e-business 10/10, e2e-digital-vehicle 10/10, e2e-property 9/9,
e2e-other 4/4, e2e-info 31/31 — 124/124. Re-verified e2e-family-agent
(12/12) and e2e-smoke-authed (24/24) still pass after the
WassiyahGenerator migration. 160/160 total across all ten suites.
This commit is contained in:
wmj
2026-08-13 21:30:46 +08:00
parent a0c70e1411
commit b9a98bd97a
12 changed files with 245 additions and 127 deletions
Download Patch File Download Diff File Expand all files Collapse all files
e2e-digital-vehicle.cjs
+20 -13
View File
@@ -2,6 +2,7 @@
// mismatched bank-mandate fields), and vehicles get correctly suggested Hibah
// (not overkill trust structure) and can actually be covered that way.
const { chromium } = require('playwright');
const { signInFreshFamily } = require('./e2e-auth-helper.cjs');
const BASE = 'https://moslem04.falahos.my/';
const results = [];
const consoleErrors = [];
@@ -13,10 +14,16 @@ async function main() {
page.on('console', m => { if (m.type() === 'error') consoleErrors.push(m.text()); });
page.on('pageerror', e => consoleErrors.push(e.message));
await page.goto(BASE, { waitUntil: 'networkidle' });
const clickTab = async label => { await page.locator('nav button.tab', { hasText: label }).click(); await page.waitForTimeout(200); };
await signInFreshFamily(page, BASE, 'e2e-digital-vehicle');
const clickTab = async label => { await page.locator('nav button.tab', { hasText: label }).click(); await page.waitForTimeout(500); };
const selectByText = async (locator, text) => {
const val = await locator.evaluate((el, t) => Array.from(el.options).find(o => o.textContent.includes(t))?.value, text);
// Options load async from Supabase now — poll until the matching one shows up.
let val;
for (let i = 0; i < 20; i++) {
val = await locator.evaluate((el, t) => Array.from(el.options).find(o => o.textContent.includes(t))?.value, text);
if (val) break;
await new Promise(r => setTimeout(r, 300));
}
await locator.selectOption(val);
};
@@ -26,7 +33,7 @@ async function main() {
await page.locator('.field:has-text("Estimated value") input').fill('150000');
await page.locator('.form-card select').first().selectOption('Digital assets');
await page.locator('button.btn-primary', { hasText: 'Add asset' }).click();
await page.waitForTimeout(200);
await page.waitForTimeout(500);
await clickTab('Coverage');
const digitalRowBefore = await page.locator('.asset-row', { hasText: 'Bitcoin' }).textContent();
@@ -34,9 +41,9 @@ async function main() {
await clickTab('Nominate');
await selectByText(page.locator('select').first(), 'Bitcoin');
await page.waitForTimeout(200);
await page.waitForTimeout(500);
await page.locator('.form-card select').nth(1).selectOption('digital-custody');
await page.waitForTimeout(200);
await page.waitForTimeout(500);
const digitalFieldsVisible = await page.locator('.trust-fields').isVisible();
record('Nomination: digital-custody-specific fields appear', digitalFieldsVisible);
@@ -44,12 +51,12 @@ async function main() {
// Switch to multisig -> warning appears (only one select in the digital-custody fields: Custody type)
const custodySelect = page.locator('.trust-fields select').nth(0);
await custodySelect.selectOption('multisig');
await page.waitForTimeout(150);
await page.waitForTimeout(500);
const multisigWarningVisible = await page.locator('.business-warning').isVisible();
record('Nomination: multi-sig custody shows the co-signer-setup warning', multisigWarningVisible);
await custodySelect.selectOption('key-escrow');
await page.waitForTimeout(150);
await page.waitForTimeout(500);
const escrowWarningVisible = await page.locator('.business-warning').isVisible();
const escrowWarningText = await page.locator('.business-warning').textContent();
record('Nomination: key-escrow shows "never store the actual key" warning', escrowWarningVisible && escrowWarningText.includes('Never store'), escrowWarningText.trim().slice(0, 150));
@@ -59,7 +66,7 @@ async function main() {
await digitalInputs.nth(1).fill('Executor Ahmad');
await digitalInputs.nth(2).fill('Sealed instructions with lawyer, ref #45');
await page.locator('button.btn-primary', { hasText: 'digital custody plan' }).click();
await page.waitForTimeout(300);
await page.waitForTimeout(600);
const digitalRowCreated = await page.locator('.nomination-row', { hasText: 'Bitcoin' }).isVisible();
record('Nomination: digital custody row created', digitalRowCreated);
@@ -80,7 +87,7 @@ async function main() {
await page.locator('.field:has-text("Estimated value") input').fill('45000');
await page.locator('.form-card select').first().selectOption('Vehicle');
await page.locator('button.btn-primary', { hasText: 'Add asset' }).click();
await page.waitForTimeout(200);
await page.waitForTimeout(500);
await clickTab('Coverage');
const vehicleRowBefore = await page.locator('.asset-row', { hasText: 'Toyota' }).textContent();
@@ -94,11 +101,11 @@ async function main() {
const linkSelect = page.locator('select').first();
await selectByText(linkSelect, 'Toyota');
await page.locator('button.btn-primary', { hasText: 'Log this hibah' }).click();
await page.waitForTimeout(200);
await page.waitForTimeout(500);
await page.locator('.guard-buttons button.btn-secondary', { hasText: 'No' }).click();
await page.waitForTimeout(200);
await page.waitForTimeout(500);
await page.locator('button.btn-primary', { hasText: 'Confirm and save' }).click();
await page.waitForTimeout(200);
await page.waitForTimeout(500);
await clickTab('Coverage');
const overallPct = await page.locator('.big-percent').textContent();