wmj/nur-falah-prevention
1
0
Fork 0
Code Issues Pull Requests 1 Actions Packages Projects Releases Wiki Activity

Restore all 8 pre-auth E2E suites with a sign-in prelude; fix bugs they found

Browse Source 
New e2e-auth-helper.cjs: shared signInFreshFamily() prelude — signs in as
the confirmed test owner account and creates a uniquely-named family per
run, so accumulated data from a previous run's assets/hibah/etc. (now
persisted in Supabase, not wiped with the browser context like localStorage
was) can never bleed into another run's percentage/coverage assertions.
All 8 suites (e2e-uat, e2e-fastpath, e2e-trust, e2e-business,
e2e-digital-vehicle, e2e-property, e2e-other, e2e-info) now call it in
place of the old anonymous page.goto(BASE).

Restoring them surfaced two real product bugs, not just test staleness:

1. WassiyahGenerator.svelte was never migrated to Supabase in the earlier
   backend work — it still called the old local storage.js load()/save()
   for assets, bequests, and witnesses, so the one-third meter silently
   read an empty local cache and always showed 0. Migrated to family-scoped
   Supabase tables (new nf_wassiyah_bequests, nf_wassiyah_settings, with
   member-scoped RLS) matching the pattern used for Hibah/Nominations/etc.

2. storage.js's exportAll() did an unguarded JSON.parse on every
   "nf."-prefixed localStorage key, but family.js stores activeFamilyId as
   a raw string (not JSON-encoded) — one malformed parse threw and silently
   aborted the whole export before the file download fired. Made exportAll
   defensive: falls back to the raw string on a parse failure instead of
   throwing.

The remaining test failures were async-timing gaps inherent to the move
from synchronous localStorage reads to async Supabase fetches: several
assertions checked <select> option counts or newly-created rows immediately
after a fixed short wait, before the async load/refresh had actually
landed. Fixed by replacing blind isVisible()/fixed-timeout checks with
proper waitFor()/polling in the test helpers (selectByText, corpus-select
population, row-creation checks) — not a product bug, but worth fixing
since the old timing assumptions no longer hold now that data is live and
shared instead of instant and local.

Results: e2e-uat 32/32, e2e-fastpath 16/16, e2e-trust 12/12,
e2e-business 10/10, e2e-digital-vehicle 10/10, e2e-property 9/9,
e2e-other 4/4, e2e-info 31/31 — 124/124. Re-verified e2e-family-agent
(12/12) and e2e-smoke-authed (24/24) still pass after the
WassiyahGenerator migration. 160/160 total across all ten suites.
This commit is contained in:
wmj
2026-08-13 21:30:46 +08:00
parent a0c70e1411
commit b9a98bd97a
12 changed files with 245 additions and 127 deletions
Download Patch File Download Diff File Expand all files Collapse all files
e2e-business.cjs
+22 -15
View File
@@ -1,6 +1,7 @@
// Verifies business interests get covered via a proper continuity instrument,
// including the sole-proprietorship warning and the waqf-enterprise redirect.
const { chromium } = require('playwright');
const { signInFreshFamily } = require('./e2e-auth-helper.cjs');
const BASE = 'https://moslem04.falahos.my/';
const results = [];
const consoleErrors = [];
@@ -12,10 +13,16 @@ async function main() {
page.on('console', m => { if (m.type() === 'error') consoleErrors.push(m.text()); });
page.on('pageerror', e => consoleErrors.push(e.message));
await page.goto(BASE, { waitUntil: 'networkidle' });
const clickTab = async label => { await page.locator('nav button.tab', { hasText: label }).click(); await page.waitForTimeout(200); };
await signInFreshFamily(page, BASE, 'e2e-business');
const clickTab = async label => { await page.locator('nav button.tab', { hasText: label }).click(); await page.waitForTimeout(500); };
const selectByText = async (locator, text) => {
const val = await locator.evaluate((el, t) => Array.from(el.options).find(o => o.textContent.includes(t))?.value, text);
// Options load async from Supabase now — poll until the matching one shows up.
let val;
for (let i = 0; i < 20; i++) {
val = await locator.evaluate((el, t) => Array.from(el.options).find(o => o.textContent.includes(t))?.value, text);
if (val) break;
await new Promise(r => setTimeout(r, 300));
}
await locator.selectOption(val);
};
@@ -25,7 +32,7 @@ async function main() {
await page.locator('.field:has-text("Estimated value") input').fill('300000');
await page.locator('.form-card select').first().selectOption('Business interest');
await page.locator('button.btn-primary', { hasText: 'Add asset' }).click();
await page.waitForTimeout(200);
await page.waitForTimeout(500);
await clickTab('Coverage');
const rowBefore = await page.locator('.asset-row', { hasText: 'Bakery' }).textContent();
@@ -34,9 +41,9 @@ async function main() {
// Go to Nominate, select business-continuity channel
await clickTab('Nominate');
await selectByText(page.locator('select').first(), 'Bakery');
await page.waitForTimeout(200);
await page.waitForTimeout(500);
await page.locator('.form-card select').nth(1).selectOption('business-continuity');
await page.waitForTimeout(200);
await page.waitForTimeout(500);
const businessFieldsVisible = await page.locator('.trust-fields').isVisible();
record('Nomination: business continuity fields appear', businessFieldsVisible);
@@ -47,25 +54,25 @@ async function main() {
// Switch to sole proprietorship -> warning should appear
await page.locator('.trust-fields select').first().selectOption('sole-prop');
await page.waitForTimeout(200);
await page.waitForTimeout(500);
const soleWarningVisible = await page.locator('.business-warning').first().isVisible();
const soleWarningText = await page.locator('.business-warning').first().textContent();
record('Nomination: sole-proprietorship shows "dies with you" warning', soleWarningVisible && soleWarningText.includes('dies with you'), soleWarningText.trim().slice(0, 150));
// Switch back to company, pick shareholder buy-sell, fill and save
await page.locator('.trust-fields select').first().selectOption('company');
await page.waitForTimeout(150);
await page.waitForTimeout(500);
const instrumentSelect = page.locator('.trust-fields select').nth(1);
await instrumentSelect.selectOption('shareholder-buy-sell');
await page.waitForTimeout(150);
await page.waitForTimeout(500);
const inputs = page.locator('.trust-fields .field input');
await inputs.nth(0).fill('Co-founder Rahman');
await inputs.nth(1).fill('Fair market valuation, Takaful-funded');
await page.locator('button.btn-primary', { hasText: 'Add business continuity instrument' }).click();
await page.waitForTimeout(300);
await page.waitForTimeout(600);
const rowCreated = await page.locator('.nomination-row', { hasText: 'Bakery' }).isVisible();
const rowCreated = await page.locator('.nomination-row', { hasText: 'Bakery' }).waitFor({ state: 'visible', timeout: 10000 }).then(() => true).catch(() => false);
record('Nomination: business continuity row created', rowCreated);
const [download] = await Promise.all([
@@ -82,9 +89,9 @@ async function main() {
// Waqf-enterprise redirect path: try selecting it and confirm Add button disables
await clickTab('Nominate');
await page.locator('.form-card select').nth(1).selectOption('business-continuity');
await page.waitForTimeout(150);
await page.waitForTimeout(500);
await page.locator('.trust-fields select').nth(1).selectOption('waqf-enterprise');
await page.waitForTimeout(150);
await page.waitForTimeout(500);
const redirectNoteVisible = await page.locator('.business-warning', { hasText: 'Family Waqf Designator' }).isVisible();
const addDisabled = await page.locator('button.btn-primary', { hasText: 'business continuity' }).isDisabled();
record('Nomination: waqf-enterprise option redirects to Family Waqf, disables Add', redirectNoteVisible && addDisabled);
@@ -98,9 +105,9 @@ async function main() {
await page.locator('.attestor-row .confirm-btn').nth(1).click();
await page.locator('.field:has-text("Date of death") input').fill('2026-08-13');
await page.locator('.field:has-text("Death certificate reference") input').fill('DC-BIZ-001');
await page.waitForTimeout(200);
await page.waitForTimeout(500);
await page.locator('button.btn-danger-solid').click();
await page.waitForTimeout(300);
await page.waitForTimeout(600);
const packetForBiz = await page.locator('.packet-row', { hasText: 'Bakery' }).isVisible();
record('Death Trigger: execution packet generated for business via continuity instrument', packetForBiz);