feat: add stickiness round — daily Sadaqah tracker + Family Tree social loop
Two features scoped from the stickiness brainstorm, sharing one digest notification pipeline: Sadaqah tracker (new tab): a private daily giving journal, not a payment processor — the app logs, it never moves money. Streak tracking follows the proven pattern from dedicated apps (Sidq, Daily Sadaqa). Family visibility is strictly limited to streak counts via a SECURITY DEFINER RPC (nf_family_sadaqah_streaks) — amounts, causes, and notes never cross the member boundary, respecting the Islamic preference for giving privately. Entries can be dedicated 'in memory of' a deceased person from the Family Tree, with a memorial count (nf_memorial_sadaqah_count, count only) surfacing on that person's card. Family Tree social loop: a 'give sadaqah in memory of' link on every deceased person's card (cross-tab jump via a small requestedTab store in nav.js), plus completeness hints (missing birth date, missing photo, no relationships linked) feeding directly into the existing Coverage Dashboard recommendations engine rather than a new UI surface. Daily digest Edge Function + pg_cron (07:00 UTC): batches into one email per family member per day, sent only when there's real content — tree activity in the last 24h, a birthday/death-anniversary today, or a weekly sadaqah recap on Sundays. An empty day sends nothing, deliberately avoiding the notification-spam failure mode the research flagged. Protected by a shared secret header since it's cron-invoked, not user-triggered. Verified with a live manual invocation before relying on the schedule. Found and fixed two real bugs in nf_family_sadaqah_streaks during E2E testing: an ambiguous unqualified 'member_id' column reference colliding with the function's OUT parameter (42702), and a bigint/int type mismatch from count(*) (42804) — both would have 400'd on every call in production. Covered by e2e-sadaqah-tree.cjs (12/12). Full regression: 280/280 across all suites.
This commit is contained in:
@@ -0,0 +1,103 @@
|
||||
// Verifies the stickiness round: the Sadaqah tracker (log, streak, family
|
||||
// privacy boundary), the Family Tree memorial-giving link, and the tree
|
||||
// completeness hints feeding the Coverage Dashboard's recommendations engine.
|
||||
const { chromium } = require('playwright');
|
||||
const { signInFreshFamily } = require('./e2e-auth-helper.cjs');
|
||||
const BASE = 'https://moslem04.falahos.my/';
|
||||
const results = [];
|
||||
const consoleErrors = [];
|
||||
function record(name, pass, detail = '') { results.push({ name, pass, detail }); console.log(`${pass ? 'PASS' : 'FAIL'} ${name}${detail ? ' — ' + detail : ''}`); }
|
||||
|
||||
async function main() {
|
||||
const browser = await chromium.launch();
|
||||
const page = await browser.newPage({ viewport: { width: 390, height: 844 } });
|
||||
page.on('console', m => { if (m.type() === 'error') consoleErrors.push(m.text()); });
|
||||
page.on('pageerror', e => consoleErrors.push(e.message));
|
||||
|
||||
await signInFreshFamily(page, BASE, 'e2e-sadaqah');
|
||||
|
||||
// ── Sadaqah tracker ──
|
||||
await page.locator('nav button[aria-label="Sadaqah"]').click();
|
||||
await page.waitForTimeout(600);
|
||||
|
||||
const zeroStreak = await page.locator('.streak-number').textContent();
|
||||
record('Sadaqah: starts at 0 streak', zeroStreak.trim() === '0', zeroStreak);
|
||||
const notYetVisible = await page.locator('.streak-today', { hasText: 'Not yet logged today' }).isVisible().catch(() => false);
|
||||
record('Sadaqah: shows "not yet logged today" before any entry', notYetVisible);
|
||||
|
||||
await page.locator('.field:has-text("Cause") input').fill('Local mosque fund');
|
||||
await page.locator('.field:has-text("Amount") input').fill('20');
|
||||
await page.locator('button.btn-primary', { hasText: "Log today's sadaqah" }).click();
|
||||
await page.waitForTimeout(1200);
|
||||
|
||||
const streakAfter = await page.locator('.streak-number').textContent();
|
||||
record('Sadaqah: logging today brings streak to 1', streakAfter.trim() === '1', streakAfter);
|
||||
const givenToday = await page.locator('.streak-card.done').isVisible().catch(() => false);
|
||||
record('Sadaqah: streak card shows "given today" state', givenToday);
|
||||
|
||||
const historyRowVisible = await page.locator('.history-row', { hasText: 'Local mosque fund' }).isVisible().catch(() => false);
|
||||
record('Sadaqah: entry appears in own history with amount', historyRowVisible);
|
||||
|
||||
// ── Family Tree: add a deceased person, verify memorial link + dedication ──
|
||||
await page.locator('nav button[aria-label="Tree"]').click();
|
||||
await page.waitForTimeout(600);
|
||||
await page.locator('.form-card .field:has-text("Full name") input').fill('Grandfather Yusuf');
|
||||
await page.locator('.form-card .field:has-text("Death date") input').fill('2010-05-01');
|
||||
await page.locator('.form-card button.btn-primary', { hasText: 'Add person' }).click();
|
||||
await page.locator('.person-card', { hasText: 'Grandfather Yusuf' }).waitFor({ state: 'visible', timeout: 10000 });
|
||||
|
||||
await page.locator('.person-summary', { hasText: 'Grandfather Yusuf' }).click();
|
||||
await page.waitForTimeout(400);
|
||||
const memorialButtonVisible = await page.locator('.person-card', { hasText: 'Grandfather Yusuf' }).locator('button', { hasText: 'Give sadaqah in memory of' }).isVisible().catch(() => false);
|
||||
record('Tree: deceased person shows a "give sadaqah in memory" link', memorialButtonVisible);
|
||||
|
||||
await page.locator('.person-card', { hasText: 'Grandfather Yusuf' }).locator('button', { hasText: 'Give sadaqah in memory of' }).click();
|
||||
await page.waitForTimeout(800);
|
||||
const jumpedToSadaqah = await page.locator('nav button.tab.active[aria-label="Sadaqah"]').isVisible().catch(() => false);
|
||||
record('Tree: memorial link navigates to the Sadaqah tab', jumpedToSadaqah);
|
||||
|
||||
// Log a dedication and confirm the memorial count appears back on the Tree
|
||||
await page.locator('.field:has-text("In memory of") select').selectOption({ label: 'Grandfather Yusuf' });
|
||||
await page.locator('.field:has-text("Cause") input').fill('In his memory');
|
||||
await page.locator('button.btn-primary', { hasText: "Log today's sadaqah" }).click();
|
||||
await page.waitForTimeout(1200);
|
||||
|
||||
await page.locator('nav button[aria-label="Tree"]').click();
|
||||
await page.waitForTimeout(600);
|
||||
await page.locator('.person-summary', { hasText: 'Grandfather Yusuf' }).click();
|
||||
await page.waitForTimeout(600);
|
||||
const memorialCountVisible = await page.locator('.memorial-count', { hasText: 'sadaqah given in their memory' }).isVisible().catch(() => false);
|
||||
record('Tree: memorial sadaqah count appears on the person card', memorialCountVisible);
|
||||
|
||||
// ── Coverage Dashboard: tree completeness hints ──
|
||||
// Add a second, incomplete person (no birth date, no photo, no relationship) to trigger hints.
|
||||
await page.locator('.form-card .field:has-text("Full name") input').fill('Cousin Zaid');
|
||||
await page.locator('.form-card button.btn-primary', { hasText: 'Add person' }).click();
|
||||
await page.waitForTimeout(1000);
|
||||
|
||||
await page.locator('nav button[aria-label="Coverage"]').click();
|
||||
await page.waitForTimeout(800);
|
||||
const birthDateHint = await page.locator('.rec-row', { hasText: 'missing a birth date' }).isVisible().catch(() => false);
|
||||
record('Coverage: recommendations flag people missing a birth date', birthDateHint);
|
||||
const orphanHint = await page.locator('.rec-row', { hasText: 'no relationships linked' }).isVisible().catch(() => false);
|
||||
record('Coverage: recommendations flag people with no relationships linked', orphanHint);
|
||||
|
||||
// ── Isolation: a different family sees none of this ──
|
||||
const isolationPage = await browser.newPage({ viewport: { width: 390, height: 844 } });
|
||||
await signInFreshFamily(isolationPage, BASE, 'e2e-sadaqah-isolation');
|
||||
await isolationPage.locator('nav button[aria-label="Sadaqah"]').click();
|
||||
await isolationPage.waitForTimeout(600);
|
||||
const isolatedStreak = await isolationPage.locator('.streak-number').textContent();
|
||||
record('Isolation: a different family starts with a 0 streak, unaffected by the above', isolatedStreak.trim() === '0', isolatedStreak);
|
||||
await isolationPage.close();
|
||||
|
||||
record('No uncaught JS console errors during full session', consoleErrors.length === 0, consoleErrors.join(' || '));
|
||||
|
||||
await browser.close();
|
||||
const passCount = results.filter(r => r.pass).length;
|
||||
const failCount = results.length - passCount;
|
||||
console.log(`\n${passCount} passed, ${failCount} failed, ${results.length} total`);
|
||||
if (failCount > 0) results.filter(r => !r.pass).forEach(r => console.log(` - ${r.name}: ${r.detail}`));
|
||||
process.exit(failCount > 0 ? 1 : 0);
|
||||
}
|
||||
main().catch(e => { console.error('SCRIPT ERROR:', e); process.exit(2); });
|
||||
Reference in New Issue
Block a user