wmj/nur-falah-prevention
1
0
Fork 0
Code Issues Pull Requests 1 Actions Packages Projects Releases Wiki Activity

Fix "Other" asset type: was suggesting a channel that doesn't exist

Browse Source 
nonprobate.js's suggestedChannel() had no case for the "Other" type (or
anything else that fell through every specific check) — it defaulted to
{ channel: 'nomination', label: 'EPF / Takaful nomination' }. Two bugs:
(1) recommending a retirement/insurance nomination for a generic asset
that could be anything (a collectible, a domain name, an heirloom) makes
no sense, and (2) 'nomination' isn't a real value in NominationRegistry's
CHANNEL_TYPES (epf/takaful/bank-mandate/trust/business-continuity/
digital-custody) — the suggestion pointed at a channel that doesn't exist.

Default now points to Hibah — the safest general-purpose fast path since
it needs no institution or legal structure, with a note to consider a
trust setup instead if the asset is high-value or income-generating.

e2e-other.cjs: new suite confirming the fixed suggestion, the corrected
in-app reasoning text, and that following it (Hibah) actually reaches
100% coverage. 4/4 passing. Re-verified all seven prior suites (32/32,
16/16, 12/12, 10/10, 10/10, 9/9, 31/31) — 136/136 total, no regressions.
This commit is contained in:
wmj
2026-08-13 18:33:22 +08:00
parent 10289e2d92
commit 4250f8da14
2 changed files with 75 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
e2e-other.cjs
+66
View File
@@ -0,0 +1,66 @@
// Verifies "Other" asset type gets a sensible suggestion (Hibah) instead of the
// previous bug: a nonsensical "EPF / Takaful nomination" suggestion pointing at a
// channel value ('nomination') that didn't even exist in the Nomination Registry.
const { chromium } = require('playwright');
const BASE = 'https://moslem04.falahos.my/';
const results = [];
const consoleErrors = [];
function record(name, pass, detail = '') { results.push({ name, pass, detail }); console.log(`${pass ? 'PASS' : 'FAIL'} ${name}${detail ? ' — ' + detail : ''}`); }
async function main() {
const browser = await chromium.launch();
const page = await browser.newPage({ viewport: { width: 390, height: 844 } });
page.on('console', m => { if (m.type() === 'error') consoleErrors.push(m.text()); });
page.on('pageerror', e => consoleErrors.push(e.message));
await page.goto(BASE, { waitUntil: 'networkidle' });
const clickTab = async label => { await page.locator('nav button.tab', { hasText: label }).click(); await page.waitForTimeout(200); };
const selectByText = async (locator, text) => {
const val = await locator.evaluate((el, t) => Array.from(el.options).find(o => o.textContent.includes(t))?.value, text);
await locator.selectOption(val);
};
await clickTab('Assets');
await page.locator('.field:has-text("Description") input').fill('Rare stamp collection');
await page.locator('.field:has-text("Estimated value") input').fill('20000');
await page.locator('.form-card select').first().selectOption('Other');
await page.locator('button.btn-primary', { hasText: 'Add asset' }).click();
await page.waitForTimeout(200);
await clickTab('Coverage');
const rowBefore = await page.locator('.asset-row', { hasText: 'stamp collection' }).textContent();
record('Coverage: "Other" asset suggests Hibah, not the old nonsense EPF/Takaful suggestion', rowBefore.includes('Hibah') && !rowBefore.includes('EPF'), rowBefore.trim().slice(0, 200));
await clickTab('Nominate');
await selectByText(page.locator('select').first(), 'stamp collection');
await page.waitForTimeout(200);
const suggestionText = await page.locator('.suggestion').textContent();
record('Nomination: suggestion for "Other" points to Hibah with sensible reasoning', suggestionText.includes('Hibah') && suggestionText.includes('safest general'), suggestionText.trim().slice(0, 200));
// Cover it via Hibah (the suggested path)
await clickTab('Hibah');
await page.locator('.field:has-text("Recipient") input').fill('My Daughter');
await page.locator('.field:has-text("Relation to you") input').fill('daughter');
await page.locator('.field:has-text("Asset / gift description") input').fill('Stamp collection gift');
await selectByText(page.locator('select').first(), 'stamp collection');
await page.locator('button.btn-primary', { hasText: 'Log this hibah' }).click();
await page.waitForTimeout(200);
await page.locator('.guard-buttons button.btn-secondary', { hasText: 'No' }).click();
await page.waitForTimeout(200);
await page.locator('button.btn-primary', { hasText: 'Confirm and save' }).click();
await page.waitForTimeout(300);
await clickTab('Coverage');
const pct = await page.locator('.big-percent').textContent();
record('Coverage: "Other" asset covered after following the Hibah suggestion', pct.trim() === '100%', pct);
record('No uncaught JS console errors', consoleErrors.length === 0, consoleErrors.join(' || '));
await browser.close();
const passCount = results.filter(r => r.pass).length;
const failCount = results.length - passCount;
console.log(`\n${passCount} passed, ${failCount} failed, ${results.length} total`);
if (failCount > 0) results.filter(r => !r.pass).forEach(r => console.log(` - ${r.name}: ${r.detail}`));
process.exit(failCount > 0 ? 1 : 0);
}
main().catch(e => { console.error('SCRIPT ERROR:', e); process.exit(2); });