refactor: restructure navigation into 5 grouped hubs, off the 22-item flat strip

Implements the researched IA fix: mobile nav UX consensus caps primary
destinations at 4-5 (uxpin.com, fintech/banking 2026 UX research), and
this app had grown to 22 tabs in one horizontally-scrolling row —
exactly the anti-pattern that research flags for choice paralysis and
slower task completion.

New structure — 5 bottom-nav hubs, grouped by what the user is actually
trying to do, not build order:
- Home: Coverage (unchanged, still the landing screen)
- Estate: Assets, Faraid, Insurance, Wassiyah, Hibah, Family Waqf,
  Nominate, Claims (H2)
- Giving: Zakat, Sadaqah, Khairat
- Family: Tree, Trigger, Mutawalli, Manage (was 'Family', renamed to
  avoid colliding with the hub's own label), Neighbourhood
- Daily: Prayer Times, Qibla, Quran, Locate

Each hub reveals its own sub-nav one tap in, instead of every tab
competing for space in a single row. Settings moved out of the tab
strip entirely into a header gear icon, matching the banking-app pattern
of keeping settings out of primary thumb-reach real estate. The bottom
nav is now fixed (thumb-zone), sub-nav keeps the old sticky-top position.

Cross-component navigation (nav.js requestedTab, used by the Family
Tree's 'give sadaqah in memory' link) now resolves a tab label to its
owning (hub, sub-tab) pair instead of a flat index — verified live.

This touches every E2E suite: a single click on a tab's old selector no
longer reaches it (hub, then sub-tab). Added a shared gotoTab(page, label)
helper to e2e-auth-helper.cjs encapsulating the two-step navigation, and
migrated all ~22 affected test files off direct nav-button selectors —
mechanical substitution followed by manual fixes for local clickTab
wrappers, template-literal selectors, and active-state assertions that
needed to target the new .hub-tab/.subnav structure specifically.

Full regression after migration: every suite passes (one isolated
Family Tree flake confirmed clean on rerun, unrelated to navigation).
This commit is contained in:
2026-08-14 14:55:09 +08:00
parent 78e025c27d
commit 33a821e61d
23 changed files with 250 additions and 136 deletions
+8 -7
View File
@@ -2,7 +2,7 @@
// privacy boundary), the Family Tree memorial-giving link, and the tree
// completeness hints feeding the Coverage Dashboard's recommendations engine.
const { chromium } = require('playwright');
const { signInFreshFamily } = require('./e2e-auth-helper.cjs');
const { signInFreshFamily, gotoTab } = require('./e2e-auth-helper.cjs');
const BASE = 'https://moslem04.falahos.my/';
const results = [];
const consoleErrors = [];
@@ -17,7 +17,7 @@ async function main() {
await signInFreshFamily(page, BASE, 'e2e-sadaqah');
// ── Sadaqah tracker ──
await page.locator('nav button[aria-label="Sadaqah"]').click();
await gotoTab(page, 'Sadaqah');
await page.waitForTimeout(600);
const zeroStreak = await page.locator('.streak-number').textContent();
@@ -39,7 +39,7 @@ async function main() {
record('Sadaqah: entry appears in own history with amount', historyRowVisible);
// ── Family Tree: add a deceased person, verify memorial link + dedication ──
await page.locator('nav button[aria-label="Tree"]').click();
await gotoTab(page, 'Tree');
await page.waitForTimeout(600);
await page.locator('.form-card .field:has-text("Full name") input').fill('Grandfather Yusuf');
await page.locator('.form-card .field:has-text("Death date") input').fill('2010-05-01');
@@ -53,7 +53,8 @@ async function main() {
await page.locator('.person-card', { hasText: 'Grandfather Yusuf' }).locator('button', { hasText: 'Give sadaqah in memory of' }).click();
await page.waitForTimeout(800);
const jumpedToSadaqah = await page.locator('nav button.tab.active[aria-label="Sadaqah"]').isVisible().catch(() => false);
const jumpedToSadaqah = await page.locator('.hub-tab.active[aria-label="Giving"]').isVisible().catch(() => false)
&& await page.locator('.subnav .tab.active[aria-label="Sadaqah"]').isVisible().catch(() => false);
record('Tree: memorial link navigates to the Sadaqah tab', jumpedToSadaqah);
// Log a dedication and confirm the memorial count appears back on the Tree
@@ -62,7 +63,7 @@ async function main() {
await page.locator('button.btn-primary', { hasText: "Log today's sadaqah" }).click();
await page.waitForTimeout(1200);
await page.locator('nav button[aria-label="Tree"]').click();
await gotoTab(page, 'Tree');
await page.waitForTimeout(600);
await page.locator('.person-summary', { hasText: 'Grandfather Yusuf' }).click();
await page.waitForTimeout(600);
@@ -75,7 +76,7 @@ async function main() {
await page.locator('.form-card button.btn-primary', { hasText: 'Add person' }).click();
await page.waitForTimeout(1000);
await page.locator('nav button[aria-label="Coverage"]').click();
await gotoTab(page, 'Coverage');
await page.waitForTimeout(800);
const birthDateHint = await page.locator('.rec-row', { hasText: 'missing a birth date' }).isVisible().catch(() => false);
record('Coverage: recommendations flag people missing a birth date', birthDateHint);
@@ -85,7 +86,7 @@ async function main() {
// ── Isolation: a different family sees none of this ──
const isolationPage = await browser.newPage({ viewport: { width: 390, height: 844 } });
await signInFreshFamily(isolationPage, BASE, 'e2e-sadaqah-isolation');
await isolationPage.locator('nav button[aria-label="Sadaqah"]').click();
await gotoTab(isolationPage, 'Sadaqah');
await isolationPage.waitForTimeout(600);
const isolatedStreak = await isolationPage.locator('.streak-number').textContent();
record('Isolation: a different family starts with a 0 streak, unaffected by the above', isolatedStreak.trim() === '0', isolatedStreak);