refactor: restructure navigation into 5 grouped hubs, off the 22-item flat strip
Implements the researched IA fix: mobile nav UX consensus caps primary destinations at 4-5 (uxpin.com, fintech/banking 2026 UX research), and this app had grown to 22 tabs in one horizontally-scrolling row — exactly the anti-pattern that research flags for choice paralysis and slower task completion. New structure — 5 bottom-nav hubs, grouped by what the user is actually trying to do, not build order: - Home: Coverage (unchanged, still the landing screen) - Estate: Assets, Faraid, Insurance, Wassiyah, Hibah, Family Waqf, Nominate, Claims (H2) - Giving: Zakat, Sadaqah, Khairat - Family: Tree, Trigger, Mutawalli, Manage (was 'Family', renamed to avoid colliding with the hub's own label), Neighbourhood - Daily: Prayer Times, Qibla, Quran, Locate Each hub reveals its own sub-nav one tap in, instead of every tab competing for space in a single row. Settings moved out of the tab strip entirely into a header gear icon, matching the banking-app pattern of keeping settings out of primary thumb-reach real estate. The bottom nav is now fixed (thumb-zone), sub-nav keeps the old sticky-top position. Cross-component navigation (nav.js requestedTab, used by the Family Tree's 'give sadaqah in memory' link) now resolves a tab label to its owning (hub, sub-tab) pair instead of a flat index — verified live. This touches every E2E suite: a single click on a tab's old selector no longer reaches it (hub, then sub-tab). Added a shared gotoTab(page, label) helper to e2e-auth-helper.cjs encapsulating the two-step navigation, and migrated all ~22 affected test files off direct nav-button selectors — mechanical substitution followed by manual fixes for local clickTab wrappers, template-literal selectors, and active-state assertions that needed to target the new .hub-tab/.subnav structure specifically. Full regression after migration: every suite passes (one isolated Family Tree flake confirmed clean on rerun, unrelated to navigation).
This commit is contained in:
@@ -2,7 +2,7 @@
|
||||
// per-member Insurance/Takaful policies, family-shared Liabilities, and
|
||||
// asset-ownership verification (proof document + dual-path confirm).
|
||||
const { chromium } = require('playwright');
|
||||
const { signInFreshFamily } = require('./e2e-auth-helper.cjs');
|
||||
const { signInFreshFamily, gotoTab } = require('./e2e-auth-helper.cjs');
|
||||
const BASE = 'https://moslem04.falahos.my/';
|
||||
const results = [];
|
||||
const consoleErrors = [];
|
||||
@@ -17,7 +17,7 @@ async function main() {
|
||||
await signInFreshFamily(page, BASE, 'e2e-insurance');
|
||||
|
||||
// ── Insurance & Takaful tab ──
|
||||
await page.locator('nav button[aria-label="Insurance"]').click();
|
||||
await gotoTab(page, 'Insurance');
|
||||
await page.waitForTimeout(600);
|
||||
|
||||
await page.locator('.form-card .field:has-text("Type") select').selectOption('takaful');
|
||||
@@ -44,7 +44,7 @@ async function main() {
|
||||
record('Insurance: editing a policy succeeds without error', consoleErrors.length === 0, consoleErrors.join(' || '));
|
||||
|
||||
// ── Asset ownership verification (Assets tab) ──
|
||||
await page.locator('nav button[aria-label="Assets"]').click();
|
||||
await gotoTab(page, 'Assets');
|
||||
await page.waitForTimeout(600);
|
||||
await page.locator('.form-card .field:has-text("Description") input').fill('Family sedan');
|
||||
await page.locator('.form-card .field:has-text("Estimated value") input').fill('45000');
|
||||
@@ -85,7 +85,7 @@ async function main() {
|
||||
record('Liabilities: removing a liability removes it from the list', !liabilityRemoved);
|
||||
|
||||
// ── Mutawalli dashboard should surface the insurance policy for this member (owner-only family: owner sees their own row) ──
|
||||
await page.locator('nav button[aria-label="Mutawalli"]').click();
|
||||
await gotoTab(page, 'Mutawalli');
|
||||
await page.waitForTimeout(800);
|
||||
const mutawalliText = await page.locator('.module').innerText().catch(() => '');
|
||||
const mutawalliGated = mutawalliText.includes('Only the mutawalli');
|
||||
@@ -94,7 +94,7 @@ async function main() {
|
||||
// ── Isolation: a second fresh family (same account) must not see this policy/liability/verification data ──
|
||||
const isolationPage = await browser.newPage({ viewport: { width: 390, height: 844 } });
|
||||
await signInFreshFamily(isolationPage, BASE, 'e2e-insurance-isolation');
|
||||
await isolationPage.locator('nav button[aria-label="Insurance"]').click();
|
||||
await gotoTab(isolationPage, 'Insurance');
|
||||
await isolationPage.waitForTimeout(600);
|
||||
const leakedPolicy = await isolationPage.locator('.policy-row', { hasText: 'Etiqa Takaful' }).isVisible().catch(() => false);
|
||||
record('Isolation: a different family sees none of this insurance data', !leakedPolicy);
|
||||
|
||||
Reference in New Issue
Block a user