refactor: restructure navigation into 5 grouped hubs, off the 22-item flat strip
Implements the researched IA fix: mobile nav UX consensus caps primary destinations at 4-5 (uxpin.com, fintech/banking 2026 UX research), and this app had grown to 22 tabs in one horizontally-scrolling row — exactly the anti-pattern that research flags for choice paralysis and slower task completion. New structure — 5 bottom-nav hubs, grouped by what the user is actually trying to do, not build order: - Home: Coverage (unchanged, still the landing screen) - Estate: Assets, Faraid, Insurance, Wassiyah, Hibah, Family Waqf, Nominate, Claims (H2) - Giving: Zakat, Sadaqah, Khairat - Family: Tree, Trigger, Mutawalli, Manage (was 'Family', renamed to avoid colliding with the hub's own label), Neighbourhood - Daily: Prayer Times, Qibla, Quran, Locate Each hub reveals its own sub-nav one tap in, instead of every tab competing for space in a single row. Settings moved out of the tab strip entirely into a header gear icon, matching the banking-app pattern of keeping settings out of primary thumb-reach real estate. The bottom nav is now fixed (thumb-zone), sub-nav keeps the old sticky-top position. Cross-component navigation (nav.js requestedTab, used by the Family Tree's 'give sadaqah in memory' link) now resolves a tab label to its owning (hub, sub-tab) pair instead of a flat index — verified live. This touches every E2E suite: a single click on a tab's old selector no longer reaches it (hub, then sub-tab). Added a shared gotoTab(page, label) helper to e2e-auth-helper.cjs encapsulating the two-step navigation, and migrated all ~22 affected test files off direct nav-button selectors — mechanical substitution followed by manual fixes for local clickTab wrappers, template-literal selectors, and active-state assertions that needed to target the new .hub-tab/.subnav structure specifically. Full regression after migration: every suite passes (one isolated Family Tree flake confirmed clean on rerun, unrelated to navigation).
This commit is contained in:
+5
-5
@@ -3,7 +3,7 @@
|
||||
// madhab selector (including honest Ja'fari gating), and the Wassiyah tab's
|
||||
// draft will document generator.
|
||||
const { chromium } = require('playwright');
|
||||
const { signInFreshFamily } = require('./e2e-auth-helper.cjs');
|
||||
const { signInFreshFamily, gotoTab } = require('./e2e-auth-helper.cjs');
|
||||
const BASE = 'https://moslem04.falahos.my/';
|
||||
const results = [];
|
||||
const consoleErrors = [];
|
||||
@@ -28,14 +28,14 @@ async function main() {
|
||||
record('Coverage: flags missing estate agent/mutawalli', noAgentRec);
|
||||
|
||||
// Add an asset to trigger the exposed-asset recommendation
|
||||
await page.locator('nav button[aria-label="Assets"]').click();
|
||||
await gotoTab(page, 'Assets');
|
||||
await page.waitForTimeout(500);
|
||||
await page.locator('.form-card .field:has-text("Description") input').fill('Savings account');
|
||||
await page.locator('.form-card .field:has-text("Estimated value") input').fill('50000');
|
||||
await page.locator('.form-card button.btn-primary', { hasText: 'Add asset' }).click();
|
||||
await page.waitForTimeout(1000);
|
||||
|
||||
await page.locator('nav button[aria-label="Coverage"]').click();
|
||||
await gotoTab(page, 'Coverage');
|
||||
await page.waitForTimeout(800);
|
||||
const exposedRec = await page.locator('.rec-row', { hasText: 'exposed to the slow' }).isVisible().catch(() => false);
|
||||
record('Coverage: flags exposed asset once one is logged', exposedRec);
|
||||
@@ -43,7 +43,7 @@ async function main() {
|
||||
record('Coverage: flags missing Wassiyah once estate has value', wassiyahRec);
|
||||
|
||||
// ── Faraid Calculator: madhab selector ──
|
||||
await page.locator('nav button[aria-label="Faraid"]').click();
|
||||
await gotoTab(page, 'Faraid');
|
||||
await page.waitForTimeout(500);
|
||||
const madhabSelectVisible = await page.locator('.field:has-text("Madhab") select').isVisible().catch(() => false);
|
||||
record('Faraid: madhab selector is present', madhabSelectVisible);
|
||||
@@ -72,7 +72,7 @@ async function main() {
|
||||
|
||||
// ── Wassiyah: draft will document generator ──
|
||||
await page.locator('.field:has-text("Madhab") select').selectOption('shafii'); // reset, avoid cross-test pollution
|
||||
await page.locator('nav button[aria-label="Wassiyah"]').click();
|
||||
await gotoTab(page, 'Wassiyah');
|
||||
await page.waitForTimeout(500);
|
||||
await page.locator('.field:has-text("Full legal name") input').fill('Ahmad bin Ismail');
|
||||
await page.locator('.field:has-text("Recipient name") input').fill('Nur Charity Foundation');
|
||||
|
||||
Reference in New Issue
Block a user