refactor: restructure navigation into 5 grouped hubs, off the 22-item flat strip
Implements the researched IA fix: mobile nav UX consensus caps primary destinations at 4-5 (uxpin.com, fintech/banking 2026 UX research), and this app had grown to 22 tabs in one horizontally-scrolling row — exactly the anti-pattern that research flags for choice paralysis and slower task completion. New structure — 5 bottom-nav hubs, grouped by what the user is actually trying to do, not build order: - Home: Coverage (unchanged, still the landing screen) - Estate: Assets, Faraid, Insurance, Wassiyah, Hibah, Family Waqf, Nominate, Claims (H2) - Giving: Zakat, Sadaqah, Khairat - Family: Tree, Trigger, Mutawalli, Manage (was 'Family', renamed to avoid colliding with the hub's own label), Neighbourhood - Daily: Prayer Times, Qibla, Quran, Locate Each hub reveals its own sub-nav one tap in, instead of every tab competing for space in a single row. Settings moved out of the tab strip entirely into a header gear icon, matching the banking-app pattern of keeping settings out of primary thumb-reach real estate. The bottom nav is now fixed (thumb-zone), sub-nav keeps the old sticky-top position. Cross-component navigation (nav.js requestedTab, used by the Family Tree's 'give sadaqah in memory' link) now resolves a tab label to its owning (hub, sub-tab) pair instead of a flat index — verified live. This touches every E2E suite: a single click on a tab's old selector no longer reaches it (hub, then sub-tab). Added a shared gotoTab(page, label) helper to e2e-auth-helper.cjs encapsulating the two-step navigation, and migrated all ~22 affected test files off direct nav-button selectors — mechanical substitution followed by manual fixes for local clickTab wrappers, template-literal selectors, and active-state assertions that needed to target the new .hub-tab/.subnav structure specifically. Full regression after migration: every suite passes (one isolated Family Tree flake confirmed clean on rerun, unrelated to navigation).
This commit is contained in:
@@ -3,6 +3,7 @@
|
||||
// contacts) alongside the existing heir notification — the one place in
|
||||
// this app where "auto-send on trigger" is actually the right behavior.
|
||||
const { chromium } = require('playwright');
|
||||
const { gotoTab } = require('./e2e-auth-helper.cjs');
|
||||
const BASE = 'https://moslem04.falahos.my/';
|
||||
const OWNER = 'nurfalah.e2etest.owner@gmail.com';
|
||||
const AGENT = 'nurfalah.e2etest.agent@gmail.com';
|
||||
@@ -29,7 +30,7 @@ async function main() {
|
||||
await ownerPage.locator('button.btn-primary', { hasText: 'Create family' }).click();
|
||||
await ownerPage.waitForTimeout(1200);
|
||||
|
||||
await ownerPage.locator('nav button[aria-label="Assets"]').click();
|
||||
await gotoTab(ownerPage, 'Assets');
|
||||
await ownerPage.waitForTimeout(500);
|
||||
await ownerPage.locator('.contacts-section .field:has-text("Name") input').fill('Emergency Test Mosque');
|
||||
await ownerPage.locator('.contacts-section .field:has-text("Category") select').selectOption('mosque');
|
||||
@@ -38,7 +39,7 @@ async function main() {
|
||||
await ownerPage.waitForTimeout(1000);
|
||||
record('Setup: mosque contact with email added', await ownerPage.locator('.contact-row', { hasText: 'Emergency Test Mosque' }).isVisible().catch(() => false));
|
||||
|
||||
await ownerPage.locator('nav button[aria-label="Family"]').click();
|
||||
await gotoTab(ownerPage, 'Manage');
|
||||
await ownerPage.waitForTimeout(500);
|
||||
await ownerPage.locator('.field:has-text("Invite by email") input').fill(AGENT);
|
||||
await ownerPage.locator('.field:has-text("Role") select').selectOption('agent');
|
||||
@@ -55,7 +56,7 @@ async function main() {
|
||||
const familyRow = agentPage.locator('.family-row', { hasText: familyName });
|
||||
if (await familyRow.count()) { await familyRow.click(); await agentPage.waitForTimeout(1000); }
|
||||
|
||||
await agentPage.locator('nav button[aria-label="Mutawalli"]').click();
|
||||
await gotoTab(agentPage, 'Mutawalli');
|
||||
await agentPage.waitForTimeout(1000);
|
||||
const memberChip = agentPage.locator('.member-chip', { hasText: 'nurfalah.e2etest.owner' });
|
||||
record('Mutawalli: owner appears as a member to fire a trigger for', await memberChip.count() === 1);
|
||||
|
||||
Reference in New Issue
Block a user