wmj/nur-falah-prevention
1
0
Fork 0
Code Issues Pull Requests 1 Actions Packages Projects Releases Wiki Activity

Cover digital assets and vehicles with proper fast-path instruments

Browse Source 
Digital assets: nonprobate.js's suggestion previously claimed channel
'bank-mandate' with label 'Multi-sig / pre-authorized release' — a
mismatch, since bank-mandate's fields (institution/nominee/reference)
don't fit crypto custody at all. New "digital-custody" channel with
custody-type-specific fields: exchange beneficiary feature, self-custody
multi-sig (warns that it only works if a living co-signer is already
configured), or key-escrow with executor (warns explicitly: never store
the actual seed phrase or private key in this app or any single record —
only a reference to WHERE access is arranged).

Vehicles/jewelry/valuables: were lumped into the same "trust" suggestion
as land, which is overkill for movable property that hands over cleanly
by a simple Hibah. Suggestion now points straight to Hibah for these;
land keeps the trust suggestion since it has no such easy path.

CoverageDashboard's suggestion-inline text simplified from an ad-hoc
ternary chain into a clean NEXT_STEP_TAB map, now correctly covering
hibah/trust/digital-custody/business-continuity.

e2e-digital-vehicle.cjs: new suite verifying digital asset exposed ->
custody-type warnings -> export -> covered, and vehicle exposed -> Hibah
suggestion (not trust) -> covered via Hibah link -> 100% combined
coverage. 10/10 passing. Re-verified all four prior suites (32/32,
16/16, 12/12, 10/10) — 80/80 total, no regressions.
This commit is contained in:
wmj
2026-08-13 17:41:25 +08:00
parent 051c9d9a94
commit 07b9f4f07a
5 changed files with 192 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files
e2e-digital-vehicle.cjs
+116
View File
@@ -0,0 +1,116 @@
// Verifies digital assets get covered via a proper digital-custody plan (not the
// mismatched bank-mandate fields), and vehicles get correctly suggested Hibah
// (not overkill trust structure) and can actually be covered that way.
const { chromium } = require('playwright');
const BASE = 'https://moslem04.falahos.my/';
const results = [];
const consoleErrors = [];
function record(name, pass, detail = '') { results.push({ name, pass, detail }); console.log(`${pass ? 'PASS' : 'FAIL'} ${name}${detail ? ' — ' + detail : ''}`); }
async function main() {
const browser = await chromium.launch();
const page = await browser.newPage({ viewport: { width: 390, height: 844 } });
page.on('console', m => { if (m.type() === 'error') consoleErrors.push(m.text()); });
page.on('pageerror', e => consoleErrors.push(e.message));
await page.goto(BASE, { waitUntil: 'networkidle' });
const clickTab = async label => { await page.locator('nav button.tab', { hasText: label }).click(); await page.waitForTimeout(200); };
const selectByText = async (locator, text) => {
const val = await locator.evaluate((el, t) => Array.from(el.options).find(o => o.textContent.includes(t))?.value, text);
await locator.selectOption(val);
};
// ── Digital asset ──
await clickTab('Assets');
await page.locator('.field:has-text("Description") input').fill('Bitcoin cold wallet');
await page.locator('.field:has-text("Estimated value") input').fill('150000');
await page.locator('.form-card select').first().selectOption('Digital assets');
await page.locator('button.btn-primary', { hasText: 'Add asset' }).click();
await page.waitForTimeout(200);
await clickTab('Coverage');
const digitalRowBefore = await page.locator('.asset-row', { hasText: 'Bitcoin' }).textContent();
record('Coverage: digital asset suggests Digital custody plan (not mismatched Multi-sig/bank-mandate label)', digitalRowBefore.includes('Digital custody plan'), digitalRowBefore.trim().slice(0, 200));
await clickTab('Nominate');
await selectByText(page.locator('select').first(), 'Bitcoin');
await page.waitForTimeout(200);
await page.locator('.form-card select').nth(1).selectOption('digital-custody');
await page.waitForTimeout(200);
const digitalFieldsVisible = await page.locator('.trust-fields').isVisible();
record('Nomination: digital-custody-specific fields appear', digitalFieldsVisible);
// Switch to multisig -> warning appears (only one select in the digital-custody fields: Custody type)
const custodySelect = page.locator('.trust-fields select').nth(0);
await custodySelect.selectOption('multisig');
await page.waitForTimeout(150);
const multisigWarningVisible = await page.locator('.business-warning').isVisible();
record('Nomination: multi-sig custody shows the co-signer-setup warning', multisigWarningVisible);
await custodySelect.selectOption('key-escrow');
await page.waitForTimeout(150);
const escrowWarningVisible = await page.locator('.business-warning').isVisible();
const escrowWarningText = await page.locator('.business-warning').textContent();
record('Nomination: key-escrow shows "never store the actual key" warning', escrowWarningVisible && escrowWarningText.includes('Never store'), escrowWarningText.trim().slice(0, 150));
const digitalInputs = page.locator('.trust-fields input');
await digitalInputs.nth(0).fill('Ledger self-custody');
await digitalInputs.nth(1).fill('Executor Ahmad');
await digitalInputs.nth(2).fill('Sealed instructions with lawyer, ref #45');
await page.locator('button.btn-primary', { hasText: 'digital custody plan' }).click();
await page.waitForTimeout(300);
const digitalRowCreated = await page.locator('.nomination-row', { hasText: 'Bitcoin' }).isVisible();
record('Nomination: digital custody row created', digitalRowCreated);
const [dlDigital] = await Promise.all([
page.waitForEvent('download'),
page.locator('.nomination-row', { hasText: 'Bitcoin' }).locator('.export-btn').click()
]);
record('Nomination: digital custody plan export downloads, no seed phrase in filename/content risk', dlDigital.suggestedFilename() === 'digital-custody-plan-draft.txt', dlDigital.suggestedFilename());
await clickTab('Coverage');
const digitalPct = await page.locator('.big-percent').textContent();
record('Coverage: digital asset now covered', digitalPct.trim() === '100%', digitalPct);
// ── Vehicle ──
await clickTab('Assets');
await page.locator('.field:has-text("Description") input').fill('Toyota Vios');
await page.locator('.field:has-text("Estimated value") input').fill('45000');
await page.locator('.form-card select').first().selectOption('Vehicle');
await page.locator('button.btn-primary', { hasText: 'Add asset' }).click();
await page.waitForTimeout(200);
await clickTab('Coverage');
const vehicleRowBefore = await page.locator('.asset-row', { hasText: 'Toyota' }).textContent();
record('Coverage: vehicle suggests Hibah directly (not overkill trust structure)', vehicleRowBefore.includes('Hibah') && !vehicleRowBefore.includes('trust setup'), vehicleRowBefore.trim().slice(0, 200));
// Cover the vehicle via Hibah
await clickTab('Hibah');
await page.locator('.field:has-text("Recipient") input').fill('My Son');
await page.locator('.field:has-text("Relation to you") input').fill('nephew');
await page.locator('.field:has-text("Asset / gift description") input').fill('Car gift');
const linkSelect = page.locator('select').first();
await selectByText(linkSelect, 'Toyota');
await page.locator('button.btn-primary', { hasText: 'Log this hibah' }).click();
await page.waitForTimeout(200);
await page.locator('.guard-buttons button.btn-secondary', { hasText: 'No' }).click();
await page.waitForTimeout(200);
await page.locator('button.btn-primary', { hasText: 'Confirm and save' }).click();
await page.waitForTimeout(200);
await clickTab('Coverage');
const overallPct = await page.locator('.big-percent').textContent();
record('Coverage: 100% after digital asset (custody) + vehicle (hibah) both covered', overallPct.trim() === '100%', overallPct);
record('No uncaught JS console errors', consoleErrors.length === 0, consoleErrors.join(' || '));
await browser.close();
const passCount = results.filter(r => r.pass).length;
const failCount = results.length - passCount;
console.log(`\n${passCount} passed, ${failCount} failed, ${results.length} total`);
if (failCount > 0) results.filter(r => !r.pass).forEach(r => console.log(` - ${r.name}: ${r.detail}`));
process.exit(failCount > 0 ? 1 : 0);
}
main().catch(e => { console.error('SCRIPT ERROR:', e); process.exit(2); });